fix: correctly throw an error if jest-environment-jsdom is missing #12749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
force-pushed
the
jsdom-resolve-error
branch
from
c3fa675 to
362c6f8
Compare
thymikee
approved these changes
Apr 26, 2022
Co-authored-by: Michał Pierzchała <[email protected]>
SimenB
commented
Apr 26, 2022
F3n67u
pushed a commit
to F3n67u/jest
that referenced
this pull request
May 2, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WIthout this, we return the
jsdommodule if it's installed, resulting in aTypeError: TestEnvironment is not a constructor.Test plan
Tested manually in a reproduction. Hard to test in this repo due to
jest-environment-jsdombeing present