fix: skip ELDHISTOGRAM for --detectOpenHandles

[0cl]

Summary

Fixes #10020 ?

I reproduced the bug and making the suggested change locally in ./node_modules/@jest/core/build/collectHandles.js seemed to be fine.

Test plan

Reproduced:

After the change, jest didn't hang:

I wasn't sure how or where to add tests for the PR - in jest/packages/jest-core/src/__tests__? apologies 😅...

[SimenB]

Thanks for sending a PR! This is missing a changelog entry and a test (as you mention in the OP). The test can bee added here: https://github.com/facebook/jest/blob/master/e2e/__tests__/detectOpenHandles.ts while fixtures are here: https://github.com/facebook/jest/tree/master/e2e/detect-open-handles

[0cl]

Thanks for pointing me in the right direction! I've added a test, but I'm not sure it's right - should a prom-client histogram object be created in the fixture?

[SimenB]

Thanks for pointing me in the right direction! I've added a test, but I'm not sure it's right - should a prom-client histogram object be created in the fixture?

Not prom-client, but we can do what they do to create the handle: https://github.com/siimon/prom-client/blob/25f9c4059d8a0f2d02ccfec7acfb64157c8b72bf/lib/metrics/eventLoopLag.js#L45-L47

[0cl]

Thank you! I've updated it based on the understanding that monitorEventLoopDelay and Histogram were only added in Node v11.10, but Jest currently supports >= 10.13

[SimenB]

Thank you!

[0cl]

sorry I didn't see that you commented earlier! thanks for your patience, it was my first time ever doing a PR, apologies for the mistakes... 😬

[SimenB]

No mistakes were made, this was a very solid contribution! Looking forward to future contributions 🙂

I'll release this tomorrow 👍

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.