Don't set $_SERVER['HOSTNAME'] in CLI SAPI

[atdt]

Matches the behavior of PHP.

[sgolemon]

D1393791

[tstarling]

strncmp() is not really right -- if there was a webserver called clinberger then you would probably want to set a HOSTNAME header in it. String::same(litstr s) is explicitly not allowed, I guess because it is expected that you use StaticString. But grepping through the codebase for handy StaticString objects to use for this, I came across:

class RuntimeOption {
  static bool ClientExecutionMode() {
    return strcmp(ExecutionMode, "cli") == 0;
  }
}

which may possibly suit your purposes. It is used in php-stream-wrapper.cpp in a similar way:

  if (!RuntimeOption::ClientExecutionMode()) {
    raise_warning("Direct access to file descriptors "
                  "is only available from command-line");
    return nullptr;
  }

[atdt]

Thanks; RuntimeOption::ClientExecutionMode() is pretty handy.