-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hhvm crashes under heavy load #1934
Labels
Comments
Thanks for reporting this. Feel free to submit a PR if you (or someone else reading this) figures this out before we do. |
I've updated to the latest nightly and this appears to have been fixed, #1937 might have been a duplicate report of this too (I had similar backtraces). Closing this issue as I'm no longer able to reproduce it. |
facebook-github-bot
pushed a commit
that referenced
this issue
Feb 22, 2024
Summary: D43401609, derived from [PR #1934](facebook/folly#1934), allows the move constructor to use `memcpy` to relocate the inline storage for relocatable types, but it copies the whole storage disregarding the previous limitation on size for trivial types (which are a subset of relocatable types). Furthermore, the same optimization is not applied to the move-assignment operator. This diff restores the size limitation (using a precise copy when relocating inline buffers that exceed it) and applies the same logic to move-assignment. Also, since now we can assume C++17 and thus `if constexpr`, I removed the unnecessary overload of `copyInlineTrivial()`, and I made the names less ambiguous. We might also benefit from special-casing relocatable types on reallocation in `makeSizeInternal()`, but that can be done separately. Reviewed By: Gownta Differential Revision: D53965673 fbshipit-source-id: 2939c03ada3b19d4fadfa11621a3e2f3afc5ccb7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The latest hhvm-nightly from the Debian 7 64-bit apt repository is crashing under heavy load.
Running hhvm with this command:
hhvm -m server -c config.hdf
config.hdf only contains:
The PHP script I'm running is as simple as:
The command I use to reproduce this:
ab -n 5000 -c 4 http://localhost:8080/helloworld.php
gdb bt on the core dump shows:
Sometimes it stops responding to requests (0% cpu usage) instead of crashing, so I'm guessing there could be a deadlock somewhere too.
The text was updated successfully, but these errors were encountered: