Add external ArrayBuffers to JSI #793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37744467 |
Summary: Pull Request resolved: facebook#793 Add a JSI API for constructing `ArrayBuffer`s from a user provided `jsi::MutableBuffer`. Changelog: [General][Added] Added ability to construct ArrayBuffers from existing memory buffers. Reviewed By: jpporto Differential Revision: D37744467 fbshipit-source-id: c5071641617af6b3a654dbc5ade1093dc54db960
neildhar
force-pushed
the
export-D37744467
branch
from
936d756 to
fb95342
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37744467 |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Aug 23, 2022
Summary: X-link: facebook/hermes#793 Add a JSI API for constructing `ArrayBuffer`s from a user provided `jsi::MutableBuffer`. Changelog: [General][Added] Added ability to construct ArrayBuffers from existing memory buffers. Reviewed By: jpporto Differential Revision: D37744467 fbshipit-source-id: 9d9ece00d1dbde341846c45fa30c935b5fa81e9a
neildhar
added a commit
to neildhar/hermes
that referenced
this pull request
Sep 22, 2022
Summary: Pull Request resolved: facebook#793 Add a JSI API for constructing `ArrayBuffer`s from a user provided `jsi::MutableBuffer`. Changelog: [General][Added] Added ability to construct ArrayBuffers from existing memory buffers. Reviewed By: jpporto Differential Revision: D37744467 fbshipit-source-id: 9d9ece00d1dbde341846c45fa30c935b5fa81e9a
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 22, 2022
Summary: Pull Request resolved: #793 Add a JSI API for constructing `ArrayBuffer`s from a user provided `jsi::MutableBuffer`. Changelog: [General][Added] Added ability to construct ArrayBuffers from existing memory buffers. Original Author: neildhar Original Reviewed By: jpporto Original Revision: D37744467 Original Git: e6d887a Reviewed By: neildhar Differential Revision: D39736262 fbshipit-source-id: 1825411929944ad3823f03eacc5d9ecddf5f73cc
neildhar
pushed a commit
to neildhar/hermes
that referenced
this pull request
Nov 22, 2022
Summary: Pull Request resolved: facebook#793 Add a JSI API for constructing `ArrayBuffer`s from a user provided `jsi::MutableBuffer`. Changelog: [General][Added] Added ability to construct ArrayBuffers from existing memory buffers. Original Author: neildhar Original Reviewed By: jpporto Original Revision: D37744467 Original Git: e6d887a Reviewed By: neildhar Differential Revision: D39736262 fbshipit-source-id: 1825411929944ad3823f03eacc5d9ecddf5f73cc
neildhar
pushed a commit
to neildhar/hermes
that referenced
this pull request
Nov 23, 2022
Summary: Pull Request resolved: facebook#793 Add a JSI API for constructing `ArrayBuffer`s from a user provided `jsi::MutableBuffer`. Changelog: [General][Added] Added ability to construct ArrayBuffers from existing memory buffers. Original Author: neildhar Original Reviewed By: jpporto Original Revision: D37744467 Original Git: e6d887a Reviewed By: neildhar Differential Revision: D39736262 fbshipit-source-id: 1825411929944ad3823f03eacc5d9ecddf5f73cc
KusStar
pushed a commit
to KusStar/react-native
that referenced
this pull request
Feb 19, 2024
Summary: X-link: facebook/hermes#793 Add a JSI API for constructing `ArrayBuffer`s from a user provided `jsi::MutableBuffer`. Changelog: [General][Added] Added ability to construct ArrayBuffers from existing memory buffers. Reviewed By: jpporto Differential Revision: D37744467 fbshipit-source-id: 9d9ece00d1dbde341846c45fa30c935b5fa81e9a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a JSI API for constructing
ArrayBuffers from a user providedjsi::MutableBuffer.Changelog: [General][Added] Added ability to construct ArrayBuffers from existing memory buffers.
Reviewed By: jpporto
Differential Revision: D37744467