-
Notifications
You must be signed in to change notification settings - Fork 648
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Enable 16KB page size binaries for RN libraries + hermes (#1557)
Summary: Pull Request resolved: #1557 X-link: facebook/react-native#47042 Add native build flags to support 16KB page size - https://developer.android.com/guide/practices/page-sizes#compile-r27-higher Changelog: [Android][Added] add cmake arguments to support 16KB page size for native libraries Reviewed By: cortinico Differential Revision: D64446876 fbshipit-source-id: 5c6b7874a8837c7ebc9b3e9267ce11fb152bf535
- Loading branch information
1 parent
a2b862e
commit e3aec0f
Showing
2 changed files
with
4 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -510,7 +510,7 @@ jobs: | |
test-e2e: | ||
runs-on: ubuntu-22.04 | ||
env: | ||
ANDROID_NDK: /usr/local/lib/android/sdk/ndk/26.1.10909125 | ||
ANDROID_NDK: /usr/local/lib/android/sdk/ndk/27.1.12297006 | ||
HERMES_WS_DIR: /home/runner/work/hermes | ||
REACT_NATIVE_OVERRIDE_HERMES_DIR: /home/runner/work/hermes/hermes | ||
steps: | ||
|
@@ -534,7 +534,7 @@ jobs: | |
uses: ReactiveCircus/[email protected] | ||
with: | ||
api-level: 29 | ||
ndk: 26.1.10909125 | ||
ndk: 27.1.12297006 | ||
cmake: 3.22.1 | ||
script: | | ||
cd ../react-native && ./gradlew -PreactNativeArchitectures=x86 :packages:rn-tester:android:app:installHermesRelease | ||
|
@@ -544,7 +544,7 @@ jobs: | |
runs-on: ubuntu-22.04 | ||
env: | ||
HERMES_WS_DIR: /home/runner/work/hermes | ||
ANDROID_NDK: /usr/local/lib/android/sdk/ndk/26.1.10909125 | ||
ANDROID_NDK: /usr/local/lib/android/sdk/ndk/27.1.12297006 | ||
steps: | ||
- name: Checkout Hermes | ||
uses: actions/[email protected] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters