Remove Runtime::getHiddenClassForPrototypeRaw

Summary:
Remove the Runtime::getHiddenClassForPrototypeRaw method, and update its single caller to use
the non-raw version.

Reviewed By: tmikov

Differential Revision: D40393784

fbshipit-source-id: 6d4fd545a3f5157ebbb80832cb25c871f320f339

include/hermes/VM/Runtime-inline.h

@@ -36,12 +36,6 @@ inline Handle<HiddenClass> Runtime::getHiddenClassForPrototype(
   return Handle<HiddenClass>::vmcast(clazz);
 }
 
-inline HiddenClass *Runtime::getHiddenClassForPrototypeRaw(
-    JSObject *proto,
-    unsigned reservedSlots) {
-  return *getHiddenClassForPrototype(proto, reservedSlots);
-}
-
 } // namespace vm
 } // namespace hermes
 

include/hermes/VM/Runtime.h

@@ -558,13 +558,6 @@ class Runtime : public PointerBase,
       JSObject *proto,
       unsigned reservedSlots);
 
-  /// Same as above but returns a raw pointer: standard warnings apply!
-  /// TODO: Delete this function once all callers are replaced with
-  /// getHiddenClassForPrototype.
-  inline HiddenClass *getHiddenClassForPrototypeRaw(
-      JSObject *proto,
-      unsigned reservedSlots);
-
   /// Return the global object.
   Handle<JSObject> getGlobal();
 

lib/VM/Interpreter.cpp

@@ -511,7 +511,7 @@ static Handle<HiddenClass> getHiddenClassForBuffer(
 
   MutableHandle<> tmpHandleKey{runtime};
   MutableHandle<HiddenClass> clazz =
-      runtime.makeMutableHandle(runtime.getHiddenClassForPrototypeRaw(
+      runtime.makeMutableHandle(*runtime.getHiddenClassForPrototype(
           vmcast<JSObject>(runtime.objectPrototype),
           JSObject::numOverlapSlots<JSObject>()));