Drawee scaletype transition #1224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e interpolated matrix calculation, to evaluate exactly between start and end matrix
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #22 ChangeImageTransform for DraweeViews is not working correctly, when ScaleType is changing during transition. This pull request resolve this issue by added custom DraweeTransform, which animates ScaleType transition correctly
InterpolatingScaleType is changed by adding start and end values of parentBounds. In pervious version it used parameter parentBounds, which changing every animation frame and it caused wrong animation behaviour. When start and end matrix is captured, there is no need to calculate it every frame, so there is also little performance improvement
Transition sample is changed due to use DraweeTransform. Also background was added in sample image, to show how animation works