-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Uri handlers / accepting arbitrary InputStreams #3
Comments
We are thinking of supporting something very similar (basically either a custom uri handler or specifying InputStream Supplier while building image request). |
I was going to say exactly the same thing...our app has data stored on disk in encrypted form as well. It's only unencrypted when in the in-memory cache. We also need a way to change the disk data (e.g., user edits a document/photo and writes it to disk, so the cache has to update)... |
I'll have to refactor some of the fetching logic to make this plugin-like, but hopefully I'll get to this some time soon. |
I'm running into this same issue. I'd like to use this in conjunction with Conceal or another file encryption mechanism which provides an |
@plamenko is there a timeline on this or any way I can "help" or use an InputStream with the current API? We would like to use in this app https://play.google.com/store/apps/details?id=fm.clean for its internal Gallery. |
I`m running into this issue too. |
@caojianfeng do you have an example code for that content provider? |
@plamenko any update regarding a custom Uri handler? |
I don't think we're likely to get to this any time soon. If someone would like to offer a pull request, I'd be willing to offer support. We're currently cleaning up old issues which aren't progressing but I'll leave this a little longer in case anyone is interested in pursuing this. |
Closing this as part of our cleanup of old issues. If anyone requires this feature, please consider implementing it and submitting a pull request. |
As I understand it, nothing was implemented in the end? |
The current Uri handlers are great for many cases, but in our app (and many others) we store our media encrypted on disk. Because of this, vanilla ContentProviders are unavailable as an option as we'd have to write a temporary unencrypted version to disk (ewww). The other option in Fresco would be to setup a localhost HTTP server that streams the unencrypted version (ewwwwww), which is a lot of unnecessary overhead.
If, however, Fresco allowed additional custom Uri handlers that provide InputStreams, we'd be golden. Alternatively, having a setImageInputStream alongside setImageUri would also suffice.
The text was updated successfully, but these errors were encountered: