allow passing OnFadeInfo for VitoView.show

Reviewed By: oprisnik Differential Revision: D64343004 fbshipit-source-id: 8d35f91e8441f0bd35c16d59d5e7b3813388901c
facebook · Oct 16, 2024 · 9b907f1 · 9b907f1
1 parent caa9739
commit 9b907f1
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 6 deletions.
diff --git a/vito/view/src/main/java/com/facebook/fresco/vito/view/VitoView.kt b/vito/view/src/main/java/com/facebook/fresco/vito/view/VitoView.kt
@@ -9,6 +9,7 @@ package com.facebook.fresco.vito.view
 
 import android.net.Uri
 import android.view.View
+import com.facebook.fresco.ui.common.OnFadeListener
 import com.facebook.fresco.vito.core.FrescoDrawableInterface
 import com.facebook.fresco.vito.core.VitoImageRequest
 import com.facebook.fresco.vito.core.VitoImageRequestListener
@@ -108,14 +109,17 @@ object VitoView {
    * Display an image
    */
   @JvmStatic
+  @JvmOverloads
   fun show(
       imageSource: ImageSource,
       imageOptions: ImageOptions,
       callerContext: Any?,
       imageListener: ImageListener?,
-      target: View
+      target: View,
+      onFadeListener: OnFadeListener? = null,
   ) {
-    VitoViewImpl2.show(imageSource, imageOptions, callerContext, imageListener, null, target)
+    VitoViewImpl2.show(
+        imageSource, imageOptions, callerContext, imageListener, null, target, onFadeListener)
   }
 
   @JvmStatic

diff --git a/vito/view/src/main/java/com/facebook/fresco/vito/view/impl/VitoViewImpl2.kt b/vito/view/src/main/java/com/facebook/fresco/vito/view/impl/VitoViewImpl2.kt
@@ -17,6 +17,7 @@ import androidx.core.view.ViewCompat
 import com.facebook.common.internal.Supplier
 import com.facebook.common.internal.Suppliers
 import com.facebook.drawee.drawable.VisibilityCallback
+import com.facebook.fresco.ui.common.OnFadeListener
 import com.facebook.fresco.vito.core.FrescoDrawableInterface
 import com.facebook.fresco.vito.core.VitoImageRequest
 import com.facebook.fresco.vito.core.VitoImageRequestListener
@@ -55,13 +56,15 @@ object VitoViewImpl2 {
       }
 
   @JvmStatic
+  @JvmOverloads
   fun show(
       imageSource: ImageSource,
       imageOptions: ImageOptions,
       callerContext: Any?,
       imageListener: ImageListener?,
       imageRequestListener: VitoImageRequestListener?,
-      target: View
+      target: View,
+      onFadeListener: OnFadeListener? = null,
   ) {
     show(
         FrescoVitoProvider.getImagePipeline()
@@ -75,16 +78,19 @@ object VitoViewImpl2 {
         callerContext,
         imageListener,
         imageRequestListener,
-        target)
+        target,
+        onFadeListener)
   }
 
   @JvmStatic
+  @JvmOverloads
   fun show(
       imageRequest: VitoImageRequest,
       callerContext: Any?,
       imageListener: ImageListener?,
       imageRequestListener: VitoImageRequestListener?,
-      target: View
+      target: View,
+      onFadeListener: OnFadeListener? = null,
   ) {
     val frescoDrawable = ensureDrawableSet(target)
     // The Drawable might be re-purposed before being cleaned up, so we release if necessary.
@@ -101,7 +107,7 @@ object VitoViewImpl2 {
               contextChain = null,
               listener = imageListener,
               perfDataListener = null,
-              onFadeListener = null,
+              onFadeListener = onFadeListener,
               viewportDimensions = Rect(0, 0, target.width, target.height),
               vitoImageRequestListener = imageRequestListener)
     }