Fix build on aarch64 gcc

Summary: Fix build errors when targeting aarch64 w/ gcc. Reviewed By: r1mikey Differential Revision: D65792446 fbshipit-source-id: 0e538648b81f76724acf03cd9fe42efa8216c8ed
facebook · Nov 13, 2024 · 5149298 · 5149298
1 parent 6e30e17
commit 5149298
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/folly/external/fast-crc32/BUCK b/folly/external/fast-crc32/BUCK
@@ -64,7 +64,7 @@ cpp_library(
     ],
     arch_preprocessor_flags = {
         "aarch64": [
-            "-march=armv8-a+crypto+crc+sha3",
+            "-march=armv8.2-a+crypto+crc+sha3",
         ],
     },
     deps = [

diff --git a/folly/external/fast-crc32/neon_crc32c_v3s4x2e_v2.cpp b/folly/external/fast-crc32/neon_crc32c_v3s4x2e_v2.cpp
@@ -76,7 +76,7 @@ CRC_AINLINE uint64x2_t crc_shift(uint32_t crc, size_t nbytes) {
   return clmul_scalar(crc, xnmodp(nbytes * 8 - 33));
 }
 
-FOLLY_TARGET_ATTRIBUTE("crc")
+FOLLY_TARGET_ATTRIBUTE("+crc")
 CRC_EXPORT bool has_neon_crc32c_v3s4x2e_v2() {
   static ElfHwCaps caps;
 

diff --git a/folly/external/fast-crc32/neon_eor3_crc32c_v8s2x4_s3.cpp b/folly/external/fast-crc32/neon_eor3_crc32c_v8s2x4_s3.cpp
@@ -76,7 +76,7 @@ CRC_AINLINE uint64x2_t crc_shift(uint32_t crc, size_t nbytes) {
   return clmul_scalar(crc, xnmodp(nbytes * 8 - 33));
 }
 
-FOLLY_TARGET_ATTRIBUTE("crc")
+FOLLY_TARGET_ATTRIBUTE("+crc")
 CRC_EXPORT bool has_neon_eor3_crc32c_v8s2x4_s3() {
   static ElfHwCaps caps;