Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stronger react dom refreshed #7569

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Stronger react dom refreshed #7569

wants to merge 10 commits into from
+1,000 −125

Commits on May 7, 2019

  1. Create placeholder prop types for react-dom HTML/SVG intrinsics

    @motiz88
    motiz88 authored and Ville Saukkonen committed May 7, 2019
    Configuration menu
    Copy the full SHA
    93e4410 View commit details
    Browse the repository at this point in the history

  2. Type some props of React DOM intrinsics 

    This is a first pass to start surfacing the architectural and practical
issues involved in typing React DOM more precisely.

In this commit:
- No event props yet!
- React global attributes like dangerouslySetInnerHTML
- Shared HTML/SVG attributes
- HTML global attributes
- A handful of SVG global attributes
- Lots of things marked TODO
- Some design choices described in comments

"Booleanish string" as a term is lifted from the React DOM source.
    @motiz88
    motiz88 authored and Ville Saukkonen committed May 7, 2019
    Configuration menu
    Copy the full SHA
    d9f3535 View commit details
    Browse the repository at this point in the history

  3. React DOM: Add autoCapitalize HTML prop

    @motiz88
    motiz88 authored and Ville Saukkonen committed May 7, 2019
    Configuration menu
    Copy the full SHA
    415976e View commit details
    Browse the repository at this point in the history

  4. React DOM: Restrict content props on void HTML elements

    @motiz88
    motiz88 authored and Ville Saukkonen committed May 7, 2019
    Configuration menu
    Copy the full SHA
    213201f View commit details
    Browse the repository at this point in the history

  5. Add definition for React DOM SyntheticPointerEvent 

    This is based on facebook/react#12507 which is
seemingly missing a couple of fields from the official spec.
Consequently this will need an update once React supports all fields.
    @motiz88
    motiz88 authored and Ville Saukkonen committed May 7, 2019
    Configuration menu
    Copy the full SHA
    a402a3e View commit details
    Browse the repository at this point in the history

  6. Add definitions for all React DOM events to HTML JSX intrinsics 

    This also refactors the main set of JSX intrinsics declarations to
support typing Event.currentTarget with each element's instance type.
    @motiz88
    motiz88 authored and Ville Saukkonen committed May 7, 2019
    Configuration menu
    Copy the full SHA
    aedba0d View commit details
    Browse the repository at this point in the history

  7. Remove empty string from React DOM booleans/enums 

    This is a design choice documented in
facebook#6727 (comment)
    @motiz88
    motiz88 authored and Ville Saukkonen committed May 7, 2019
    Configuration menu
    Copy the full SHA
    694e943 View commit details
    Browse the repository at this point in the history

  8. update tests

    Ville Saukkonen committed May 7, 2019
    Configuration menu
    Copy the full SHA
    5c2f919 View commit details
    Browse the repository at this point in the history

  9. allow null in class name

    Ville Saukkonen committed May 7, 2019
    Configuration menu
    Copy the full SHA
    028b316 View commit details
    Browse the repository at this point in the history

  10. allow string in ReactDOM$Number

    Ville Saukkonen committed May 7, 2019
    Configuration menu
    Copy the full SHA
    ab9d235 View commit details
    Browse the repository at this point in the history