move tests to "classic-only"

Summary: These tests only make sense in classic mode, so I'm moving them to folders with the prefix `classic_only_`. When classic mode is not supported anymore these tests will be deleted. Reviewed By: jbrown215 Differential Revision: D25601278 fbshipit-source-id: cface29b9c7bb55c4b88f600b1ff1e6cca6b018d
facebook · Dec 17, 2020 · 8efa4d5 · 8efa4d5
1 parent 28f5aa8
commit 8efa4d5
Show file tree

Hide file tree

Showing 28 changed files with 41 additions and 47 deletions.
diff --git a/tests/autofix_insert_type/.flowconfig b/tests/autofix_insert_type/.flowconfig
@@ -7,7 +7,6 @@
 [lints]
 
 [options]
-types_first=false
 no_flowlib=false
 
 [strict]
diff --git a/tests/autofix_insert_type/autofix_insert_type.exp b/tests/autofix_insert_type/autofix_insert_type.exp
@@ -103,30 +103,6 @@ class A {
 function foo(x: (() => A)) {}
 foo(new A().m);
 No errors!
-class-poly-0.js 5 10
-// @flow
-
-class D<T> {}
-class C<T> extends D<T> {
-  m(x: T): T {
-    //$FlowFixMe[escaped-generic]
-    return x;
-  }
-}
-
-module.exports = C;
-No errors!
-comments-0.js 4 33
-// @flow
-
-// BEFORE FUNCTION
-export function test (x: number): string {
-  // ONE
-  const a = 4 + x; // END OF a = 4...
-  // TWO
-  return /* BETWEEEN */ `${a}` // END OF return ...
-} // END
-No errors!
 dictionary.js 12 12
 // @flow
 
@@ -383,24 +359,6 @@ replacement-dictionary.js 3 3 --strategy=generalize
   ab: null, 'a b': null, 'a"b': null, '1': null, '"': null, ' ': null, '_': null, '': null,
   get 'x'() {return null;}, set 'y'(z: string) {} } );
 No errors!
-replacement-function.js 7 47
-// @flow
-
-// Spaced out comments /* non-comments
-
-// BEFORE FUNCTION
-export //too many comments
-function /*Random*/ test /*weird*/ (x: number): string /*Comments*/ {
-// ONE
-/* Two */  const a = 4 + x;    // END OF a = 4...
-
-
-
-  // Three
-
-  return /* BETWEEEN */ `${a}` // END OF return ...
-} // END */
-No errors!
 replacement-object.js 2 16
 // @flow
 var obj = {n(y): string {return this.m(y);},m(x) {return "";}}

diff --git a/tests/autofix_insert_type/test.sh b/tests/autofix_insert_type/test.sh
@@ -34,8 +34,6 @@ do_file "class-0.js" 4 3 4 4
 do_file "class-1.js" 5 6
 do_file "class-2.js" 4 6
 do_file "class-3.js" 9 15
-do_file "class-poly-0.js" 5 10
-do_file "comments-0.js" 4 33
 do_file "dictionary.js" 12 12
 do_file "func-0.js" 3 26
 do_file "func-1.js" 3 18
@@ -57,7 +55,6 @@ do_file "replacement-array.js" 5 15 --strategy=generalize
 do_file "replacement-arrow.js" 3 13
 do_file "replacement-class.js" 5 7
 do_file "replacement-dictionary.js" 3 3 --strategy=generalize
-do_file "replacement-function.js" 7 47
 do_file "replacement-object.js" 2 16
 
 do_file "func-0.js" 4 14 4 15

diff --git a/tests/classic_only_autofix_insert_type/.flowconfig b/tests/classic_only_autofix_insert_type/.flowconfig
@@ -0,0 +1,13 @@
+[ignore]
+
+[include]
+
+[libs]
+
+[lints]
+
+[options]
+no_flowlib=false
+types_first=false
+
+[strict]
diff --git a/tests/autofix_insert_type/class-poly-0.js → ..._only_autofix_insert_type/class-poly-0.js b/tests/autofix_insert_type/class-poly-0.js → ..._only_autofix_insert_type/class-poly-0.js
diff --git a/tests/classic_only_autofix_insert_type/classic_only_autofix_insert_type.exp b/tests/classic_only_autofix_insert_type/classic_only_autofix_insert_type.exp
@@ -0,0 +1 @@
+Found 0 errors
diff --git a/tests/autofix_insert_type/comments-0.js → ...ic_only_autofix_insert_type/comments-0.js b/tests/autofix_insert_type/comments-0.js → ...ic_only_autofix_insert_type/comments-0.js
diff --git a/...tofix_insert_type/replacement-function.js → ...tofix_insert_type/replacement-function.js b/...tofix_insert_type/replacement-function.js → ...tofix_insert_type/replacement-function.js
diff --git a/tests/classic_only_autofix_insert_type/test.sh b/tests/classic_only_autofix_insert_type/test.sh
@@ -0,0 +1,27 @@
+#!/bin/bash
+# Copyright (c) Facebook, Inc. and its affiliates.
+#
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
+
+## Correct tests
+
+TEMP_DIR=tmp
+mkdir $TEMP_DIR
+
+do_file() {
+  FILE="$1"; shift;
+  echo "$FILE" "$@"
+  cp "$FILE" "$TEMP_DIR/$FILE"
+  assert_ok "$FLOW" autofix insert-type --strip-root --quiet --in-place --path="$TEMP_DIR/out.js" \
+    "$TEMP_DIR/$FILE" "$@"
+  cat "$TEMP_DIR/out.js"
+  rm "$TEMP_DIR/$FILE"
+  assert_ok "$FLOW" force-recheck "$TEMP_DIR/out.js"
+  assert_ok "$FLOW" status
+  rm "$TEMP_DIR/out.js"
+}
+
+do_file "class-poly-0.js" 4 33
+do_file "comments-0.js" 4 33
+do_file "replacement-function.js" 7 47
diff --git a/tests/misc/.flowconfig → tests/classic_only_misc/.flowconfig b/tests/misc/.flowconfig → tests/classic_only_misc/.flowconfig
diff --git a/tests/misc/A.js → tests/classic_only_misc/A.js b/tests/misc/A.js → tests/classic_only_misc/A.js
diff --git a/tests/misc/B.js → tests/classic_only_misc/B.js b/tests/misc/B.js → tests/classic_only_misc/B.js
diff --git a/tests/misc/C.js → tests/classic_only_misc/C.js b/tests/misc/C.js → tests/classic_only_misc/C.js
diff --git a/tests/misc/D.js → tests/classic_only_misc/D.js b/tests/misc/D.js → tests/classic_only_misc/D.js
diff --git a/tests/misc/E.js → tests/classic_only_misc/E.js b/tests/misc/E.js → tests/classic_only_misc/E.js
diff --git a/tests/misc/F.js → tests/classic_only_misc/F.js b/tests/misc/F.js → tests/classic_only_misc/F.js
diff --git a/tests/misc/G.js → tests/classic_only_misc/G.js b/tests/misc/G.js → tests/classic_only_misc/G.js
diff --git a/tests/misc/misc.exp → ...s/classic_only_misc/classic_only_misc.exp b/tests/misc/misc.exp → ...s/classic_only_misc/classic_only_misc.exp
diff --git a/tests/missing_annotation/.flowconfig → ...assic_only_missing_annotation/.flowconfig b/tests/missing_annotation/.flowconfig → ...assic_only_missing_annotation/.flowconfig
diff --git a/tests/missing_annotation/array.js → .../classic_only_missing_annotation/array.js b/tests/missing_annotation/array.js → .../classic_only_missing_annotation/array.js
diff --git a/tests/missing_annotation/async_return.js → ...c_only_missing_annotation/async_return.js b/tests/missing_annotation/async_return.js → ...c_only_missing_annotation/async_return.js
diff --git a/...missing_annotation/missing_annotation.exp → ...ation/classic_only_missing_annotation.exp b/...missing_annotation/missing_annotation.exp → ...ation/classic_only_missing_annotation.exp
diff --git a/tests/missing_annotation/infer.js → .../classic_only_missing_annotation/infer.js b/tests/missing_annotation/infer.js → .../classic_only_missing_annotation/infer.js
diff --git a/tests/missing_annotation/invariant_this.js → ...only_missing_annotation/invariant_this.js b/tests/missing_annotation/invariant_this.js → ...only_missing_annotation/invariant_this.js
diff --git a/tests/type_destructors_merged_t/.flowconfig → ...nly_type_destructors_merged_t/.flowconfig b/tests/type_destructors_merged_t/.flowconfig → ...nly_type_destructors_merged_t/.flowconfig
@@ -1,4 +1,3 @@
 [options]
 types_first=false
 all=true
-
diff --git a/...rs_merged_t/type_destructors_merged_t.exp → ...lassic_only_type_destructors_merged_t.exp b/...rs_merged_t/type_destructors_merged_t.exp → ...lassic_only_type_destructors_merged_t.exp
diff --git a/tests/type_destructors_merged_t/merged.js → ..._only_type_destructors_merged_t/merged.js b/tests/type_destructors_merged_t/merged.js → ..._only_type_destructors_merged_t/merged.js
diff --git a/tests/type_destructors_merged_t/test.js → ...ic_only_type_destructors_merged_t/test.js b/tests/type_destructors_merged_t/test.js → ...ic_only_type_destructors_merged_t/test.js