[easy] switch Autocomplete_js.Acjsx to record argument

Summary: record > big tuple Reviewed By: mroch Differential Revision: D25593035 fbshipit-source-id: 6808bb2ee8d42d3122a260380613234f3a2f3503
facebook · Dec 17, 2020 · 27142d1 · 27142d1
1 parent 38d2dcd
commit 27142d1
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/src/services/autocomplete/autocompleteService_js.ml b/src/services/autocomplete/autocompleteService_js.ml
@@ -745,9 +745,18 @@ let autocomplete_get_results ~options ~reader ~cx ~file_sig ~ast ~typed_ast trig
         in_optional_chain
         ac_loc
         ~tparams )
-  | Some (tparams, ac_loc, Acjsx (ac_name, used_attr_names, cls)) ->
+  | Some (tparams, ac_loc, Acjsx { attribute_name; used_attr_names; component_t }) ->
     ( "Acjsx",
-      autocomplete_jsx ~reader cx file_sig typed_ast cls ac_name ~used_attr_names ac_loc ~tparams )
+      autocomplete_jsx
+        ~reader
+        cx
+        file_sig
+        typed_ast
+        component_t
+        attribute_name
+        ~used_attr_names
+        ac_loc
+        ~tparams )
   | Some (tparams, ac_loc, Actype { token }) ->
     ( "Actype",
       autocomplete_unqualified_type

diff --git a/src/services/autocomplete/autocomplete_js.ml b/src/services/autocomplete/autocomplete_js.ml
@@ -34,7 +34,11 @@ type autocomplete_type =
       in_optional_chain: bool;
     }
   (* JSX attributes *)
-  | Acjsx of string * SSet.t * Type.t
+  | Acjsx of {
+      attribute_name: string;
+      used_attr_names: SSet.t;
+      component_t: Type.t;
+    }
   (* JSX text child *)
   | Acjsxtext
 
@@ -176,7 +180,7 @@ class process_request_searcher (from_trigger_character : bool) (cursor : Loc.t)
       in
       Base.Option.iter
         ~f:(fun (attribute_name, loc, component_t) ->
-          this#find loc (Acjsx (attribute_name, used_attr_names, component_t)))
+          this#find loc (Acjsx { attribute_name; used_attr_names; component_t }))
         found;
       super#jsx_opening_element elt