upgrade tests/lint_cli_* to types-first

Summary:
Makes tests compatible with Flow types-first, by
* removing unnecessary exports that used to cause signature-verification errors
* adding annotations when needed
* converting `var` to `const`

Reviewed By: gkz

Differential Revision: D25609131

fbshipit-source-id: 701f7cc6b8235cfdb9d7cb6f2473d32d1d449179

tests/lint_cli_add_all/.flowconfig

@@ -5,7 +5,6 @@
 [libs]
 
 [options]
-types_first=false
 
 [lints]
 all=off

tests/lint_cli_add_all/cycle_B.js

@@ -1,5 +1,5 @@
-var a = require("./cycle_A.js");
+const a = require("./cycle_A.js");
 
-var b = {a: a, b: 0};
+const b = {a: a, b: 0};
 
 module.exports = b;

tests/lint_cli_add_all/cycle_C.js

@@ -1,10 +1,10 @@
-var vars = require("./cycle_B.js")
+const vars = require("./cycle_B.js")
 
 function f(x) {
   if (x); /* sketchy because of uses */
 }
 
-var resNull = f(null);
-var resB = f(vars.b);
+const resNull: void = f(null);
+const resB: void = f(vars.b);
 
 module.exports = {resA: resNull, resB: resB};

tests/lint_cli_add_all/lint_cli_add_all.exp

@@ -8,12 +8,12 @@ Sketchy null check on number [1] which is potentially 0. Perhaps you meant to ch
             ^
 
 References:
-   cycle_B.js:3:19
-   3| var b = {a: a, b: 0};
-                        ^ [1]
-   cycle_C.js:7:17
-   7| var resNull = f(null);
-                      ^^^^ [2]
+   cycle_B.js:3:21
+   3| const b = {a: a, b: 0};
+                          ^ [1]
+   cycle_C.js:7:25
+   7| const resNull: void = f(null);
+                              ^^^^ [2]
 
 
 Error -------------------------------------------------------------------------------------------- fully_across_B.js:4:6

tests/lint_cli_add_single/.flowconfig

@@ -5,7 +5,6 @@
 [libs]
 
 [options]
-types_first=false
 
 [lints]
 all=off

tests/lint_cli_add_single/cycle_B.js

@@ -1,5 +1,5 @@
-var a = require("./cycle_A.js");
+const a = require("./cycle_A.js");
 
-var b = {a: a, b: 0};
+const b = {a: a, b: 0};
 
 module.exports = b;

tests/lint_cli_add_single/cycle_C.js

@@ -4,7 +4,7 @@ function f(x) {
   if (x); /* sketchy because of uses */
 }
 
-var resNull = f(null);
-var resB = f(vars.b);
+const resNull: void = f(null);
+const resB: void = f(vars.b);
 
 module.exports = {resA: resNull, resB: resB};

tests/lint_cli_add_single/lint_cli_add_single.exp

@@ -8,12 +8,12 @@ Sketchy null check on number [1] which is potentially 0. Perhaps you meant to ch
             ^
 
 References:
-   cycle_B.js:3:19
-   3| var b = {a: a, b: 0};
-                        ^ [1]
-   cycle_C.js:7:17
-   7| var resNull = f(null);
-                      ^^^^ [2]
+   cycle_B.js:3:21
+   3| const b = {a: a, b: 0};
+                          ^ [1]
+   cycle_C.js:7:25
+   7| const resNull: void = f(null);
+                              ^^^^ [2]
 
 
 Error -------------------------------------------------------------------------------------------- fully_across_B.js:4:6

tests/lint_cli_no_override_all/.flowconfig

@@ -5,7 +5,6 @@
 [libs]
 
 [options]
-types_first=false
 
 [lints]
 all=error

tests/lint_cli_no_override_all/cycle_B.js

@@ -1,5 +1,5 @@
-var a = require("./cycle_A.js");
+const a = require("./cycle_A.js");
 
-var b = {a: a, b: 0};
+const b = {a: a, b: 0};
 
 module.exports = b;

tests/lint_cli_no_override_all/cycle_C.js

@@ -4,7 +4,7 @@ function f(x) {
   if (x); /* sketchy because of uses */
 }
 
-var resNull = f(null);
-var resB = f(vars.b);
+const resNull: void = f(null);
+const resB: void = f(vars.b);
 
 module.exports = {resA: resNull, resB: resB};

tests/lint_cli_no_override_all/lint_cli_no_override_all.exp

@@ -8,12 +8,12 @@ Sketchy null check on number [1] which is potentially 0. Perhaps you meant to ch
             ^
 
 References:
-   cycle_B.js:3:19
-   3| var b = {a: a, b: 0};
-                        ^ [1]
-   cycle_C.js:7:17
-   7| var resNull = f(null);
-                      ^^^^ [2]
+   cycle_B.js:3:21
+   3| const b = {a: a, b: 0};
+                          ^ [1]
+   cycle_C.js:7:25
+   7| const resNull: void = f(null);
+                              ^^^^ [2]
 
 
 Error -------------------------------------------------------------------------------------------- fully_across_B.js:4:6

tests/lint_cli_no_override_none/.flowconfig

@@ -5,7 +5,6 @@
 [libs]
 
 [options]
-types_first=false
 
 [lints]
 all=off

tests/lint_cli_no_override_none/cycle_B.js

@@ -1,5 +1,5 @@
-var a = require("./cycle_A.js");
+const a = require("./cycle_A.js");
 
-var b = {a: a, b: 0};
+const b = {a: a, b: 0};
 
 module.exports = b;

tests/lint_cli_no_override_none/cycle_C.js

@@ -4,7 +4,7 @@ function f(x) {
   if (x); /* sketchy because of uses */
 }
 
-var resNull = f(null);
-var resB = f(vars.b);
+const resNull: void = f(null);
+const resB: void = f(vars.b);
 
 module.exports = {resA: resNull, resB: resB};

tests/lint_cli_remove_all/.flowconfig

@@ -5,7 +5,6 @@
 [libs]
 
 [options]
-types_first=false
 
 [lints]
 all=error

tests/lint_cli_remove_all/cycle_B.js

@@ -1,5 +1,5 @@
-var a = require("./cycle_A.js");
+const a = require("./cycle_A.js");
 
-var b = {a: a, b: 0};
+const b = {a: a, b: 0};
 
 module.exports = b;

tests/lint_cli_remove_all/cycle_C.js

@@ -4,7 +4,7 @@ function f(x) {
   if (x); /* sketchy because of uses */
 }
 
-var resNull = f(null);
-var resB = f(vars.b);
+const resNull: void = f(null);
+const resB: void = f(vars.b);
 
 module.exports = {resA: resNull, resB: resB};

tests/lint_cli_remove_single/.flowconfig

@@ -5,7 +5,6 @@
 [libs]
 
 [options]
-types_first=false
 
 [lints]
 all=error

tests/lint_cli_remove_single/cycle_B.js

@@ -1,5 +1,5 @@
-var a = require("./cycle_A.js");
+const a = require("./cycle_A.js");
 
-var b = {a: a, b: 0};
+const b = {a: a, b: 0};
 
 module.exports = b;

tests/lint_cli_remove_single/cycle_C.js

@@ -4,7 +4,7 @@ function f(x) {
   if (x); /* sketchy because of uses */
 }
 
-var resNull = f(null);
-var resB = f(vars.b);
+const resNull: void = f(null);
+const resB: void = f(vars.b);
 
 module.exports = {resA: resNull, resB: resB};

tests/lint_suppressions_all/.flowconfig

@@ -1,5 +1,4 @@
 [options]
-types_first=false
 all=true
 
 [lints]

tests/lint_suppressions_all/cycle_B.js

@@ -1,5 +1,5 @@
-var a = require("./cycle_A.js");
+const a = require("./cycle_A.js");
 
-var b = {a: a, b: 0};
+const b = {a: a, b: 0};
 
 module.exports = b;

tests/lint_suppressions_all/cycle_C.js

@@ -4,7 +4,7 @@ function f(x) {
   if (x); /* sketchy because of uses */
 }
 
-var resNull = f(null);
-var resB = f(vars.b);
+const resNull: void = f(null);
+const resB: void = f(vars.b);
 
 module.exports = {resA: resNull, resB: resB};

tests/lint_suppressions_all/lint_suppressions_all.exp

@@ -8,12 +8,12 @@ Sketchy null check on number [1] which is potentially 0. Perhaps you meant to ch
             ^
 
 References:
-   cycle_B.js:3:19
-   3| var b = {a: a, b: 0};
-                        ^ [1]
-   cycle_C.js:7:17
-   7| var resNull = f(null);
-                      ^^^^ [2]
+   cycle_B.js:3:21
+   3| const b = {a: a, b: 0};
+                          ^ [1]
+   cycle_C.js:7:25
+   7| const resNull: void = f(null);
+                              ^^^^ [2]
 
 
 Error -------------------------------------------------------------------------------------------- fully_across_B.js:4:6

tests/lint_suppressions_single/.flowconfig

@@ -1,5 +1,4 @@
 [options]
-types_first=false
 all=true
 
 [lints]

tests/lint_suppressions_single/cycle_B.js

@@ -1,5 +1,5 @@
-var a = require("./cycle_A.js");
+const a = require("./cycle_A.js");
 
-var b = {a: a, b: 0};
+const b = {a: a, b: 0};
 
 module.exports = b;

tests/lint_suppressions_single/cycle_C.js

@@ -4,7 +4,7 @@ function f(x) {
   if (x); /* sketchy because of uses */
 }
 
-var resNull = f(null);
-var resB = f(vars.b);
+const resNull: void = f(null);
+const resB: void = f(vars.b);
 
 module.exports = {resA: resNull, resB: resB};

tests/lint_suppressions_single/lint_suppressions_single.exp

@@ -8,12 +8,12 @@ Sketchy null check on number [1] which is potentially 0. Perhaps you meant to ch
             ^
 
 References:
-   cycle_B.js:3:19
-   3| var b = {a: a, b: 0};
-                        ^ [1]
-   cycle_C.js:7:17
-   7| var resNull = f(null);
-                      ^^^^ [2]
+   cycle_B.js:3:21
+   3| const b = {a: a, b: 0};
+                          ^ [1]
+   cycle_C.js:7:25
+   7| const resNull: void = f(null);
+                              ^^^^ [2]
 
 
 Error -------------------------------------------------------------------------------------------- fully_across_B.js:4:6

tests/sketchy_null_check/.flowconfig

@@ -1,5 +1,4 @@
 [options]
-types_first=false
 all=true
 
 [lints]

tests/sketchy_null_check/cycle_B.js

@@ -1,5 +1,5 @@
-var a = require("./cycle_A.js");
+const a = require("./cycle_A.js");
 
-var b = {a: a, b: 0};
+const b = {a: a, b: 0};
 
 module.exports = b;

tests/sketchy_null_check/cycle_C.js

@@ -1,10 +1,10 @@
-var vars = require("./cycle_B.js")
+const vars = require("./cycle_B.js")
 
 function f(x) {
   if (x); /* sketchy because of uses */
 }
 
-var resNull = f(null);
-var resB = f(vars.b);
+const resNull: void = f(null);
+const resB: void = f(vars.b);
 
 module.exports = {resA: resNull, resB: resB};

tests/sketchy_null_check/sketchy_null_check.exp

@@ -8,12 +8,12 @@ Sketchy null check on number [1] which is potentially 0. Perhaps you meant to ch
             ^
 
 References:
-   cycle_B.js:3:19
-   3| var b = {a: a, b: 0};
-                        ^ [1]
-   cycle_C.js:7:17
-   7| var resNull = f(null);
-                      ^^^^ [2]
+   cycle_B.js:3:21
+   3| const b = {a: a, b: 0};
+                          ^ [1]
+   cycle_C.js:7:25
+   7| const resNull: void = f(null);
+                              ^^^^ [2]
 
 
 Error -------------------------------------------------------------------------------------------- fully_across_B.js:4:6