Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] js/react-flipper-example Switch to React 18.2.0 & bump deps #4901

Conversation

Pranav-yadav
Copy link
Contributor

@Pranav-yadav Pranav-yadav commented Jun 29, 2023

Summary

This diff refactors js/react-flipper-example to React & ReactDOM 18.2.0 and bumps all deps to the latest.

  • Also, specifies the js-flipper dep version as * which is taken care of by the relative-deps script.
  • Deletes logo.svg from src/

Scope: js/react-flipper-example

Changelog

[General][Changed] - [Refactor] js/react-flipper-example Switch to React 18.2.0 & bump deps.

Test Plan

  • Should pass js-flipper / build-react-example (pull_request) workflow.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 29, 2023
@Pranav-yadav Pranav-yadav changed the title Refactor: js/react-flipper-example Switch to React 18 & bump deps Refactor: js/react-flipper-example Switch to React 18.x & bump deps Jun 29, 2023
@Pranav-yadav Pranav-yadav force-pushed the Pranav-yadav/flipper-eg-react18 branch from 27ca714 to a06132b Compare July 1, 2023 06:24
@Pranav-yadav Pranav-yadav force-pushed the Pranav-yadav/flipper-eg-react18 branch from a06132b to ae2873d Compare July 8, 2023 13:09
@Pranav-yadav Pranav-yadav changed the title Refactor: js/react-flipper-example Switch to React 18.x & bump deps [Refactor]js/react-flipper-example Switch to React 18.2.0 & bump deps Jul 8, 2023
@Pranav-yadav Pranav-yadav changed the title [Refactor]js/react-flipper-example Switch to React 18.2.0 & bump deps [Refactor] js/react-flipper-example Switch to React 18.2.0 & bump deps Jul 8, 2023
@Pranav-yadav
Copy link
Contributor Author

Cc: @lblasa & @passy :)

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@passy merged this pull request in cb4352a.

@Pranav-yadav Pranav-yadav deleted the Pranav-yadav/flipper-eg-react18 branch August 5, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants