-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Enforce minimum Node JS to v18
#4897
Conversation
|
There are a few CI issues with our sub-projects. Could you take a look? |
Ohh, sorry. This is a stack! |
Summary: This diff bumps Node JS to `v18` in CI Pipeline. Related PR: 1. #4897 ## Changelog [General] [Changed] - Bump Node JS to `v18` in CI Pipeline Pull Request resolved: #4898 Test Plan: - Should pass tests & builds successfully Reviewed By: lblasa Differential Revision: D47128828 Pulled By: passy fbshipit-source-id: b8d829b273898bf5e297560fbbdbafba80285b33
b52bd18
to
eed25fa
Compare
Np. |
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Woohoo! Let's ship it. |
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Thanks for review ❤️. |
Summary:
Enforce minimum Node JS version to
v18
via/package.json#engines
Node JS
v16
's EOL is2023-09-11
:https://nodejs.org/en/blog/announcements/nodejs16-eol
react-native also bumped Node JS to
v18
recently Breaking - Bump minimum Node version from 16 to 18 react-native#37709 (RN0.73
will probably enforce min Node JSv18
)Bumps in CI via:
v18
in CI Pipeline #4898Changelog:
[General] [Breaking] - Enforce minimum Node JS
v18
Test Plan: