Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent Function Upgrade for Enhanced Performance 🚀 #4889

Closed

Conversation

sanjaiyan-dev
Copy link
Contributor

@sanjaiyan-dev sanjaiyan-dev commented Jun 27, 2023

This pull request (PR) aims to significantly enhance the performance of the Facebook Flipper package by implementing concurrent execution of functions using the Promise.all feature. By leveraging the power of concurrent processing, this upgrade optimizes CPU resource utilization, resulting in improved overall efficiency.

I sincerely apologize for any mistakes or omissions that may have occurred during the implementation, and I appreciate your understanding.

Changes Made:

  • Refactored functions to utilize Promise.all for concurrent execution.
  • Introduced concurrent processing to maximize CPU resource utilization.

Benefits:

  • Enhanced Performance: The introduction of concurrent execution allows multiple functions to be processed simultaneously, reducing overall execution time and boosting performance.
  • Efficient CPU Resource Utilization: By leveraging concurrent processing, the PR ensures better utilization of available CPU resources, leading to improved efficiency and responsiveness.

Additional Notes:
Your thorough review of the changes made in this PR is greatly appreciated. Kindly provide any feedback, suggestions, or concerns you may have. Thank you for your time and consideration.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 27, 2023
@sanjaiyan-dev sanjaiyan-dev marked this pull request as ready for review June 27, 2023 19:35
@passy
Copy link
Member

passy commented Jun 29, 2023

This looks great! Would you mind quickly running yarn fix over it? There are a few minor linting problems.

@sanjaiyan-dev
Copy link
Contributor Author

This looks great! Would you mind quickly running yarn fix over it? There are a few minor linting problems.

Please accept my sincere apologies for not being able to run the yarn lint command. If it's not too much trouble, could you kindly assist me by executing it on my behalf or offering guidance? I am currently utilizing GitHub's cloud-based web editor. Once again, I deeply regret any inconvenience this may have caused. (@passy)

@sanjaiyan-dev
Copy link
Contributor Author

😔

@passy
Copy link
Member

passy commented Jul 7, 2023

Nice! Thanks so much for doing this!

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@sanjaiyan-dev
Copy link
Contributor Author

@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@passy Thank you so much :)

facebook-github-bot pushed a commit that referenced this pull request Jul 17, 2023
Summary:
Republishing sanjaiyan-dev's PR #4889 running `git rebase` because of a conflict.

Pull Request resolved: #4918

Reviewed By: lblasa

Differential Revision: D47294545

Pulled By: passy

fbshipit-source-id: 74904ec6179ed5a3bab6f9b701c3cd769ecad3bf
@passy
Copy link
Member

passy commented Jul 18, 2023

Merged in 7cef828. Thanks again!

@passy passy closed this Jul 18, 2023
@sanjaiyan-dev sanjaiyan-dev deleted the sanjaiyan-async-parallel branch July 18, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants