Set the socket attrs in the EVB thread context to avoid a race condit…

…ion reported by TSAN

Summary: Set the socket attrs in the EVB thread context to avoid a race condition reported by TSAN

Reviewed By: yfeldblum

Differential Revision: D23216182

fbshipit-source-id: 219854ef1844c1acd909019a5897fc6922406921

thrift/lib/cpp2/server/ThriftServer.cpp

@@ -330,16 +330,19 @@ void ThriftServer::setup() {
       // zeroCopyEnableFunc_ is valid
       bool useZeroCopy = !!zeroCopyEnableFunc_;
       for (auto& socket : getSockets()) {
-        socket->setShutdownSocketSet(wShutdownSocketSet_);
-        socket->setAcceptRateAdjustSpeed(acceptRateAdjustSpeed_);
-        socket->setZeroCopy(useZeroCopy);
-
-        try {
-          socket->setTosReflect(tosReflect_);
-        } catch (std::exception const& ex) {
-          LOG(ERROR) << "Got exception setting up TOS reflect: "
-                     << folly::exceptionStr(ex);
-        }
+        auto* evb = socket->getEventBase();
+        evb->runImmediatelyOrRunInEventBaseThreadAndWait([&] {
+          socket->setShutdownSocketSet(wShutdownSocketSet_);
+          socket->setAcceptRateAdjustSpeed(acceptRateAdjustSpeed_);
+          socket->setZeroCopy(useZeroCopy);
+
+          try {
+            socket->setTosReflect(tosReflect_);
+          } catch (std::exception const& ex) {
+            LOG(ERROR) << "Got exception setting up TOS reflect: "
+                       << folly::exceptionStr(ex);
+          }
+        });
       }
 
       // Notify handler of the preServe event