Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest): update cache function for new Jest 27 API #408

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Nov 16, 2020

@SimenB
Copy link
Contributor Author

SimenB commented Nov 16, 2020

An alternative would be to use https://github.com/facebook/jest/tree/e5816610eaa6d8aa6b4742909d7495be77f8f347/packages/jest-create-cache-key-function which will handle both 26 and 27 version of the signature

@eps1lon
Copy link

eps1lon commented Jun 14, 2021

This change is required to use the react-native preset in jest 27: https://github.com/reduxjs/react-redux/pull/1733/checks?check_run_id=2820313064#step:6:25

@gabrielgrover
Copy link

Any news on when this will be merged?

@enstulen
Copy link

enstulen commented Jul 9, 2021

This would be great to have merged!

@leggomuhgreggo
Copy link

If anyone is here because they're using react-native -- you can use yarn resolutions as described here

"resolutions": {
    "react-native/@jest/create-cache-key-function": "^27.0.2"
 }

@leecommamichael
Copy link

I also have this issue after upgrading to Jest 27. I'm up to date on React Native as well.

@prometheas
Copy link

prometheas commented Aug 19, 2021

Same here. Jest 27 breaks my project's CI 😅 though I'll add this curious tidbit: for whatever reason, it actually runs properly locally (macOS 11.4), but specifically fails when run this very simple Github workflow based on ubuntu-latest:

name: Node.js CI

on:
  push:
    branches: [master]
  pull_request:
    branches: [master]

jobs:
  build:
    runs-on: ubuntu-latest

    strategy:
      matrix:
        node-version: [14.x]
        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/

    steps:
      - uses: actions/checkout@v2
      - name: Use Node.js ${{ matrix.node-version }}
        uses: actions/setup-node@v1
        with:
          node-version: ${{ matrix.node-version }}
      - run: npm ci
      - run: npm run lint
      - run: npm test

@amq
Copy link

amq commented Sep 13, 2021

Tagging the latest releaser @GijsWeterings

@kdnutrien
Copy link

Getting this merged would be excellent. Breaking us too on a Jest 27 upgrade attempt.

@GijsWeterings GijsWeterings merged commit 438aa46 into facebook:main Sep 26, 2021
@GijsWeterings
Copy link
Contributor

LGTM :)

@SimenB SimenB deleted the patch-2 branch September 27, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.