Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isomorphic-fetch not maintained, consider switching to cross-fetch #363

Closed
ebdrup opened this issue Feb 27, 2020 · 0 comments · Fixed by #385
Closed

isomorphic-fetch not maintained, consider switching to cross-fetch #363

ebdrup opened this issue Feb 27, 2020 · 0 comments · Fixed by #385

Comments

@ebdrup
Copy link

ebdrup commented Feb 27, 2020

isomorphic-fetch is not maintained, consider switching to cross-fetch that is a fork of isomorphic-fetch that is actively maintained (I'm suggesting it for selfish purposes to make our bundle smaller :-) )
zpao added a commit to zpao/fbjs that referenced this issue Apr 6, 2020
@zpao
Replace isomorphic-fetch with cross-fetch
f09072d 
cross-fetch seems to be a drop-in replacement for isomorphic-fetch, but
more actively maintained. I also added a test to ensure we maintain the
behavior of using global fetch if available (eg React-Native)
closes facebook#363
@zpao zpao mentioned this issue Apr 6, 2020
Merged
@zpao zpao closed this as completed in #385 Apr 6, 2020
zpao added a commit that referenced this issue Apr 6, 2020
@zpao
Replace isomorphic-fetch with cross-fetch (#385)
16620e3 
cross-fetch seems to be a drop-in replacement for isomorphic-fetch, but
more actively maintained. I also added a test to ensure we maintain the
behavior of using global fetch if available (eg React-Native)
closes #363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace isomorphic-fetch with cross-fetch zpao/fbjs
1 participant
@ebdrup