Get rid of flow lib by inlining Promise.prototype.done polyfill

facebook · Sep 15, 2016 · 1cd633e · 1cd633e
1 parent 2c6edc4
commit 1cd633e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 54 deletions.
diff --git a/packages/fbjs/flow/lib/Promise.js b/packages/fbjs/flow/lib/Promise.js
diff --git a/packages/fbjs/flow/lib/dev.js b/packages/fbjs/flow/lib/dev.js
diff --git a/packages/fbjs/src/.flowconfig b/packages/fbjs/src/.flowconfig
@@ -5,9 +5,6 @@
 [include]
 ../node_modules/promise
 
-[libs]
-../flow/lib
-
 [options]
 module.system=haste
 

diff --git a/packages/fbjs/src/core/Deferred.js b/packages/fbjs/src/core/Deferred.js
@@ -57,7 +57,16 @@ class Deferred<Tvalue, Treason> {
   }
 
   done(): void {
-    Promise.prototype.done.apply(this._promise, arguments);
+    // Embed the polyfill for the non-standard Promise.prototype.done so that
+    // users of the open source fbjs don't need a custom lib for Promise
+    const promise = arguments.length ?
+      this._promise.then.apply(this._promise, arguments) :
+      this._promise;
+    promise.then(undefined, function(err) {
+      setTimeout(function() {
+        throw err;
+      }, 0);
+    });
   }
 
   isSettled(): boolean {