Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[README.md] fix typo #610

Closed
truongd3 opened this issue Aug 18, 2024 · 3 comments
Closed

[README.md] fix typo #610

truongd3 opened this issue Aug 18, 2024 · 3 comments

Comments

@truongd3
Copy link

truongd3 commented Aug 18, 2024 •
edited
Loading

Facebook PHP Business SDK Issue

Fix typo errors in README.md and CHANGELOG.md

Description

README.md

  1. Missing Dollar Sign for Variable
    In the Create Objects section, the AdSetFields::CAMPAIGN_ID is missing a $ before campaign_id

  2. Code Block Syntax Highlighting
    Add shell tag for second code block line 335

CHANGELOG.md

  1. Missing Parenthesis for Link Attachment
    In the Unreleased v11.0.0, the link attached is missing a pair of parenthesis
@stcheng
Copy link
Contributor

stcheng commented Aug 19, 2024

Hi @truongd3 would you mind submit a PR to address the issues?

@truongd3
Copy link
Author

truongd3 commented Aug 22, 2024 •
edited
Loading

Dear @stcheng , thank you very much for allowing me to submit a PR! I tried but it said my permission is denied. Can you please let me know what I should do?

Update: I knew what to do!

@truongd3 truongd3 mentioned this issue Aug 22, 2024
Closed
@truongd3
Copy link
Author

Hi @stcheng , this is my PR. Have a great day!

@stcheng stcheng closed this as completed Aug 23, 2024
facebook-github-bot referenced this issue Aug 23, 2024
@facebook-github-bot
Fix typo in readme and changelog (#611)
1fbdf60 
Summary:
## Issue [https://github.com/facebook/facebook-php-business-sdk/issues/610](https://github.com/facebook/facebook-php-business-sdk/issues/610#issue-2472108763)
Fix typo errors in [README.md](README.md) and [CHANGELOG.md](CHANGELOG.md)

## Description
#### README.md
1. **Missing Dollar Sign for Variable** ✅
In the [**Create Objects**](https://github.com/facebook/facebook-php-business-sdk/blob/main/README.md#create-objects) section, the `AdSetFields::CAMPAIGN_ID` is missing a `$` before `campaign_id`

2. **Code Block Syntax Highlighting** ✅
Add `shell` tag for [second code block line 335](https://github.com/facebook/facebook-php-business-sdk/blob/main/README.md#debug)

#### CHANGELOG.md
1. **Missing Parenthesis for Link Attachment** ✅
In the [**Unreleased v11.0.0**](https://github.com/facebook/facebook-php-business-sdk/blob/main/CHANGELOG.md#v1100), the link attached is missing a pair of parenthesis

Pull Request resolved: #611

Reviewed By: yoongyj

Differential Revision: D61666440

Pulled By: stcheng

fbshipit-source-id: c7e78eaa9611782d96a05850c51c73807d8de0af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stcheng @truongd3