Skip to content

Commit

Permalink
Fix typo in readme and changelog (#611)
Browse files Browse the repository at this point in the history
Summary:
## Issue [https://github.com/facebook/facebook-php-business-sdk/issues/610](https://github.com/facebook/facebook-php-business-sdk/issues/610#issue-2472108763)
Fix typo errors in [README.md](README.md) and [CHANGELOG.md](CHANGELOG.md)

## Description
#### README.md
1. **Missing Dollar Sign for Variable** ✅
In the [**Create Objects**](https://github.com/facebook/facebook-php-business-sdk/blob/main/README.md#create-objects) section, the `AdSetFields::CAMPAIGN_ID` is missing a `$` before `campaign_id`

2. **Code Block Syntax Highlighting** ✅
Add `shell` tag for [second code block line 335](https://github.com/facebook/facebook-php-business-sdk/blob/main/README.md#debug)

#### CHANGELOG.md
1. **Missing Parenthesis for Link Attachment** ✅
In the [**Unreleased v11.0.0**](https://github.com/facebook/facebook-php-business-sdk/blob/main/CHANGELOG.md#v1100), the link attached is missing a pair of parenthesis

Pull Request resolved: #611

Reviewed By: yoongyj

Differential Revision: D61666440

Pulled By: stcheng

fbshipit-source-id: c7e78eaa9611782d96a05850c51c73807d8de0af
  • Loading branch information
Truong Dang authored and facebook-github-bot committed Aug 23, 2024
1 parent e1a3866 commit 1fbdf60
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ All notable changes to this project will be documented in this file.


### Changed
- Graph API call upgrade to [v11.0]https://developers.facebook.com/docs/graph-api/changelog/version11.0
- Graph API call upgrade to [v11.0](https://developers.facebook.com/docs/graph-api/changelog/version11.0)

## v10.0.1

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ $adset = $account->createAdSet(
array(),
array(
AdSetFields::NAME => 'My Test AdSet',
AdSetFields::CAMPAIGN_ID => campaign_id,
AdSetFields::CAMPAIGN_ID => $campaign_id,
AdSetFields::DAILY_BUDGET => 150,
AdSetFields::START_TIME => (new \DateTime("+1 week"))->format(\DateTime::ISO8601),
AdSetFields::END_TIME => (new \DateTime("+2 week"))->format(\DateTime::ISO8601),
Expand Down Expand Up @@ -332,7 +332,7 @@ $account->read(array('id'));
```

When running this code, this cURL request will be printed to the console as:
```
```shell
curl -G \
-d 'fields=id' \
-d 'access_token=<access_token>' \
Expand Down

0 comments on commit 1fbdf60

Please sign in to comment.