Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, set things up for my workflow #540

Closed
wants to merge 10 commits into from

Conversation

chessai
Copy link
Contributor

@chessai chessai commented Oct 16, 2020

This PR accomplishes several things:

  • removes dist-newstyle (local build artifacts should not be checked in)
  • extends the .gitignore to include many common build artifacts/editor artifacts
  • allow more modern dependencies (upper bounds of many were out of date by one or two years' worth of releases)
  • upgrade stack lts (9.2 -> 14.2) to GHC 8.6.5
  • regenerate .travis.yml using the now-standard haskell-ci (many haskell core libraries use this), instead of the outdated script that was maintained by hvr; as a precursor to this, the tested-with versions were updated
  • add nix to accomodate my typical workflow/assist anyone used to a nix-based workflow (this does not interefere with already existing stack-based workflow)
  • add Makefile to accommodate my make-based workflow

@chessai
Copy link
Contributor Author

chessai commented Oct 16, 2020

Interestingly, it looks like the test suite fails on GHC-8.8.3 but not 8.6.5 or 8.4.4:

      KA Tests
        Corpus Tests:              FAIL
          tests/Duckling/Testing/Asserts.hs:92:
          2 tokens found for "ოცი დოლარი და ორმოცდასამი ცენტი"
      KA Tests
        Corpus Tests:              FAIL
          tests/Duckling/Testing/Asserts.hs:91:
          empty result on "ოცდაერთი"
      KA Tests
        Corpus Tests:              FAIL (0.07s)
          tests/Duckling/Testing/Asserts.hs:92:
          2 tokens found for "ხუთშაბათს 10-ის ნახევრიდან 11:00-მდე"

@chessai
Copy link
Contributor Author

chessai commented Oct 16, 2020

The test failure on a newer compiler is out of scope for this PR. I will open up a separate issue. For now I will change the .travis.yml to only care about GHC 8.4.4 and 8.6.5

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chessai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chessai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@chessai
Copy link
Contributor Author

chessai commented Oct 29, 2020

Closing - will make necessary changes in a separate PR

@chessai chessai closed this Oct 29, 2020
@chessai chessai deleted the chessai/setup branch November 6, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants