Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nteract project as a user #890

Merged
merged 2 commits into from
Aug 7, 2018
Merged

Conversation

willingc
Copy link
Contributor

@willingc willingc commented Aug 6, 2018

Motivation

As suggested by @yangshun in PR #888, I've submitted the nteract project as a user.

We ❤️ Docusaurus.

Have you read the Contributing Guidelines on pull requests?

Yes.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 6, 2018
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Aug 6, 2018

Deploy preview for docusaurus-preview ready!

Built with commit d05b836

https://deploy-preview-890--docusaurus-preview.netlify.com

@yangshun yangshun changed the title add nteract project as a user Add nteract project as a user Aug 6, 2018
@yangshun
Copy link
Contributor

yangshun commented Aug 6, 2018

@willingc Thanks for the PR! Do you happen to know why the test are failing? The CI output doesn't tell me much. Could you run the test command locally and see if it passes?

@willingc
Copy link
Contributor Author

willingc commented Aug 7, 2018

Sorry about that @yangshun. I had an extra line feed in one of the lines. 😊

@yangshun yangshun merged commit e27e18b into facebook:master Aug 7, 2018
@yangshun
Copy link
Contributor

yangshun commented Aug 7, 2018

Thanks for your contribution @willingc !

@willingc willingc deleted the add-logo branch August 7, 2018 03:44
@JoelMarcey
Copy link
Contributor

Thank you for using Docusaurus, @willingc 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants