Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add dark mode version of BrowserStack logo #8709

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

fredrikstave
Copy link
Contributor

@fredrikstave fredrikstave commented Feb 24, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I saw something that bugged me in the README and I knew how to easily fix it 🙂

Dark logo on dark background 😢
image

Test Plan

  • Open two browser windows side by side
  • In one open your profile settings, in the other open this pull request
  • Go to the README.md file and preview the changes
  • Cycle through the different theme settings in the second tab, while refreshing the pull request tab
  • You should see the BrowserStack logo at the bottom of the README change from light to dark
  • (Bonus) If you want to try syncing appearance with the system settings as well, it should update instantly
  • Check that the added code looks okay

Test links

Profile settings link: https://github.com/settings/appearance

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@netlify
Copy link

netlify bot commented Feb 24, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 320d32d
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63f8f001c574ca00089e259b
😎 Deploy Preview https://deploy-preview-8709--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 89 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 82 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber slorber added pr: documentation This PR works on the website or other text documents in the repo. and removed pr: documentation This PR works on the website or other text documents in the repo. labels Mar 2, 2023
@slorber slorber changed the title docs(): add dark mode version of BrowserStack logo docs: add dark mode version of BrowserStack logo Mar 2, 2023
@slorber
Copy link
Collaborator

slorber commented Mar 2, 2023

😄 thanks

@slorber slorber merged commit e78a6a6 into facebook:main Mar 2, 2023
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants