Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-docs): expose all lib files through exports #7962

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

JPeer264
Copy link
Contributor

@JPeer264 JPeer264 commented Aug 17, 2022

Pre-flight checklist

Related issues/PRs

I hope that is OK that I deleted half of the template, as it would mostly duplicate #7961.


@Josh-Cena This would be out of scope of this PR, but I noticed that there are exports in theme-common and theme-search-algolia as well, to make it consistent should we add this line there as well?

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 17, 2022
@Josh-Cena Josh-Cena changed the title chore(plugin-docs): expose lib in package.json (closes #7961) chore(plugin-docs): expose all lib files through exports Aug 17, 2022
@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Aug 17, 2022
@Josh-Cena
Copy link
Collaborator

but I noticed that there are exports in theme-common and theme-search-algolia as well, to make it consistent should we add this line there as well?

Everything in theme-common is already exported—same as theme-search-algolia.

@netlify
Copy link

netlify bot commented Aug 17, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 2468136
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62fca8898eda61000ab00342
😎 Deploy Preview https://deploy-preview-7962--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 54 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 85 🟢 99 🟢 100 🟢 100 🟢 90 Report

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Josh-Cena Josh-Cena merged commit c29218e into facebook:main Aug 18, 2022
@JPeer264 JPeer264 deleted the feature/expose-lib branch August 18, 2022 06:27
@JPeer264
Copy link
Contributor Author

@Josh-Cena general question. Is there some general release plan or roadmap when new releases are coming out? Or is this just based on specific new features?

@slorber
Copy link
Collaborator

slorber commented Aug 26, 2022

We wrote about our release process here:

If you have any question after reading that, please submit and we'll improve our release process doc

@JPeer264
Copy link
Contributor Author

@slorber thanks for these links they helped a lot. Also recently [email protected] has been deployed, but it seems that these changes were not part of the retro compatible commits. I was just wondering if there is a reason if this is not backwards compatible or not. Would it be possible by any chance to add this to some release? For now we use the nightly builds, which work fine, but still for me it feels a bit unsafe to use them in the long(er) run. Sorry for bringing this little thing up again.

@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Sep 28, 2022
@slorber
Copy link
Collaborator

slorber commented Sep 28, 2022

@JPeer264 added the tag to backport for next stable release ;)

slorber pushed a commit that referenced this pull request Oct 28, 2022
chore(plugin-docs): expose lib in package.json (closes #7961)

Co-authored-by: Jan Peer Stoecklmair <[email protected]>
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making getSlug available from outside of the packages
5 participants