-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(theme-classic): split AnnouncementBar, increase z-index, use shadow #7940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- z-index above navbar - use shadow instead of border
slorber
added
pr: polish
This PR adds a very minor behavior improvement that users will enjoy.
domain: theme
Related to the default theme components
labels
Aug 11, 2022
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: +740 B (0%) Total Size: 813 kB
ℹ️ View Unchanged
|
slorber
added
the
to backport
This PR is planned to be backported to a stable version of Docusaurus
label
Aug 12, 2022
slorber
added a commit
that referenced
this pull request
Sep 1, 2022
slorber
added
backported
This PR has been backported to a stable version of Docusaurus
and removed
to backport
This PR is planned to be backported to a stable version of Docusaurus
labels
Sep 28, 2022
This was referenced Sep 29, 2022
slorber
added a commit
to adnanhashmi09/docusaurus
that referenced
this pull request
Oct 6, 2022
FYI the z-index change is reverted in #8163 because of facebookincubator/infima#275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backported
This PR has been backported to a stable version of Docusaurus
CLA Signed
Signed Facebook CLA
domain: theme
Related to the default theme components
pr: polish
This PR adds a very minor behavior improvement that users will enjoy.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Note: I didn't extract a Layout/Container component as it wasn't very easy to design those properly without introducing some extra dom nodes.
Test Plan
preview vs prod (almost not visible in dark mode), subtle changes only: shadow instead of border + 1px additional space.
Before:
After:
Test links
Deploy preview: https://deploy-preview-7940--docusaurus-2.netlify.app/
Related issues/PRs
#7827