Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): use has instead of get to test for existence in ExecEnv #7763

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

This is better because the has check may be proxified differently from a get check. We should always use has for existence.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Jul 11, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners July 11, 2022 11:06
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 11, 2022
@netlify
Copy link

netlify bot commented Jul 11, 2022

[V2]

Name Link
🔨 Latest commit 2646f9d
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62cc042f72a56d00082a61e8
😎 Deploy Preview https://deploy-preview-7763--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 73 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 83 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena changed the title refactor(core): use has instead of get to test for existence refactor(core): use has instead of get to test for existence in ExecEnv Jul 11, 2022
@github-actions
Copy link

Size Change: +10 B (0%)

Total Size: 805 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 52.6 kB 0 B
website/build/assets/css/styles.********.css 106 kB 0 B
website/build/assets/js/main.********.js 607 kB +10 B (0%)
website/build/index.html 38.9 kB 0 B

compressed-size-action

@Josh-Cena Josh-Cena merged commit 636d470 into main Jul 11, 2022
@Josh-Cena Josh-Cena deleted the refactor-ee branch July 11, 2022 11:19
slorber pushed a commit that referenced this pull request Jul 14, 2022
…nv (#7763)

refactor(core): use has instead of get to test for existence
This was referenced May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants