-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(theme-translations): complete ko translations #7762
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
89eb962
Improve Algolia Search Korean Translations
anaclumos 9ea7395
Merge branch 'facebook:main' into main
anaclumos 3c14521
Update theme-search-algolia.json
Josh-Cena 9ba6873
Remove Duplicate Colon
anaclumos 4be3b5d
remove redundnacy
anaclumos 6861b03
Update theme-search-algolia.json
Josh-Cena 8b9eb20
Translate Search By
anaclumos aa3e5d3
Merge branch 'main' of https://github.com/anaclumos/docusaurus
anaclumos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
52 changes: 26 additions & 26 deletions
52
packages/docusaurus-theme-translations/locales/ko/theme-search-algolia.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,35 +1,35 @@ | ||
| { | ||
| "theme.SearchBar.label": "검색", | ||
| "theme.SearchBar.seeAll": "{count}개의 결과 확인하기", | ||
| "theme.SearchModal.errorScreen.helpText": "You might want to check your network connection.", | ||
| "theme.SearchModal.errorScreen.titleText": "Unable to fetch results", | ||
| "theme.SearchModal.footer.closeKeyAriaLabel": "Escape key", | ||
| "theme.SearchModal.footer.closeText": "to close", | ||
| "theme.SearchModal.footer.navigateDownKeyAriaLabel": "Arrow down", | ||
| "theme.SearchModal.footer.navigateText": "to navigate", | ||
| "theme.SearchModal.footer.navigateUpKeyAriaLabel": "Arrow up", | ||
| "theme.SearchModal.errorScreen.helpText": "인터넷 연결을 다시 확인하시기 바랍니다.", | ||
| "theme.SearchModal.errorScreen.titleText": "결과를 불러올 수 없음", | ||
| "theme.SearchModal.footer.closeKeyAriaLabel": "Esc 키", | ||
| "theme.SearchModal.footer.closeText": "로 종료", | ||
| "theme.SearchModal.footer.navigateDownKeyAriaLabel": "화살표 아래 키", | ||
| "theme.SearchModal.footer.navigateText": "로 이동", | ||
| "theme.SearchModal.footer.navigateUpKeyAriaLabel": "화살표 위 키", | ||
| "theme.SearchModal.footer.searchByText": "Search by", | ||
| "theme.SearchModal.footer.selectKeyAriaLabel": "Enter key", | ||
| "theme.SearchModal.footer.selectText": "to select", | ||
| "theme.SearchModal.noResultsScreen.noResultsText": "No results for", | ||
| "theme.SearchModal.noResultsScreen.reportMissingResultsLinkText": "Let us know.", | ||
| "theme.SearchModal.noResultsScreen.reportMissingResultsText": "Believe this query should return results?", | ||
| "theme.SearchModal.noResultsScreen.suggestedQueryText": "Try searching for", | ||
| "theme.SearchModal.placeholder": "Search docs", | ||
| "theme.SearchModal.searchBox.cancelButtonText": "Cancel", | ||
| "theme.SearchModal.searchBox.resetButtonTitle": "Clear the query", | ||
| "theme.SearchModal.startScreen.favoriteSearchesTitle": "Favorite", | ||
| "theme.SearchModal.startScreen.noRecentSearchesText": "No recent searches", | ||
| "theme.SearchModal.startScreen.recentSearchesTitle": "Recent", | ||
| "theme.SearchModal.startScreen.removeFavoriteSearchButtonTitle": "Remove this search from favorites", | ||
| "theme.SearchModal.startScreen.removeRecentSearchButtonTitle": "Remove this search from history", | ||
| "theme.SearchModal.startScreen.saveRecentSearchButtonTitle": "Save this search", | ||
| "theme.SearchModal.footer.selectKeyAriaLabel": "엔터 키", | ||
| "theme.SearchModal.footer.selectText": "로 선택", | ||
| "theme.SearchModal.noResultsScreen.noResultsText": "검색 결과 없음", | ||
| "theme.SearchModal.noResultsScreen.reportMissingResultsLinkText": "알려주시기 바랍니다.", | ||
| "theme.SearchModal.noResultsScreen.reportMissingResultsText": "검색 결과가 없는 것이 오류라고 생각되십니까?", | ||
| "theme.SearchModal.noResultsScreen.suggestedQueryText": "다른 추천 검색어", | ||
| "theme.SearchModal.placeholder": "문서 검색", | ||
| "theme.SearchModal.searchBox.cancelButtonText": "취소", | ||
| "theme.SearchModal.searchBox.resetButtonTitle": "검색어 초기화", | ||
| "theme.SearchModal.startScreen.favoriteSearchesTitle": "즐겨찾기", | ||
| "theme.SearchModal.startScreen.noRecentSearchesText": "최근 검색어 없음", | ||
| "theme.SearchModal.startScreen.recentSearchesTitle": "최근", | ||
| "theme.SearchModal.startScreen.removeFavoriteSearchButtonTitle": "이 검색어를 즐겨찾기에서 삭제", | ||
| "theme.SearchModal.startScreen.removeRecentSearchButtonTitle": "이 검색어를 최근 검색어에서 삭제", | ||
| "theme.SearchModal.startScreen.saveRecentSearchButtonTitle": "이 검색어를 저장", | ||
| "theme.SearchPage.algoliaLabel": "Algolia로 검색", | ||
| "theme.SearchPage.documentsFound.plurals": "{count}개 문서를 찾았습니다.", | ||
| "theme.SearchPage.documentsFound.plurals": "{count}개의 문서를 찾았습니다.", | ||
| "theme.SearchPage.emptyResultsTitle": "문서를 검색합니다.", | ||
| "theme.SearchPage.existingResultsTitle": "\"{query}\"개 검색 결과가 있습니다.", | ||
| "theme.SearchPage.fetchingNewResults": "새로운 검색 결과를 불러오는 중 입니다...", | ||
| "theme.SearchPage.existingResultsTitle": "\"{query}\" 검색 결과", | ||
| "theme.SearchPage.fetchingNewResults": "새로운 검색 결과를 불러오는 중입니다.", | ||
| "theme.SearchPage.inputLabel": "검색", | ||
| "theme.SearchPage.inputPlaceholder": "여기에 검색할 키워드를 입력하세요.", | ||
| "theme.SearchPage.inputPlaceholder": "검색어를 입력하세요.", | ||
| "theme.SearchPage.noResultsText": "검색 결과가 없습니다." | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is fine?
I did translate it for zh btw. I understand the order of words may be a bit weird in Asian languages. I basically translated it as "Search provider".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually makes more sense to me, from the keyboard glyph on the modal.
If these translations will only be used for the below screenshot, it suits well.
If it’s used somewhere else, then I might need to review it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, "Search by algolia" is only in this one place AFAICT. It's fine if you don't want to translate it. I did translate it for zh:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, do you mean “Search By”? Well then it’s whatsoever. I think it wouldn’t really matter if that remains in English. I didn’t think of any better alternatives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's awkward in Chinese as well. I wouldn't mind since it's not informative anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could do
검색 제공.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the context, I misunderstood your first comment. I have added translation keys for
Search by.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fine either way, translated or untranslated.