Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump devcontainer to node 18 #7726

Merged
merged 3 commits into from
Jul 6, 2022
Merged

chore: bump devcontainer to node 18 #7726

merged 3 commits into from
Jul 6, 2022

Conversation

jqshuv
Copy link
Contributor

@jqshuv jqshuv commented Jul 5, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I decited to bump this version because I've tried to open this repo in a Remote-Container in vscode and got the error that you need at least NodeJS 16.

Test Plan

I've rebuilded the devcontainer and it worked without any errors.

image

Test links

Deploy preview: https://deploy-preview-7726--docusaurus-2.netlify.app/

@facebook-github-bot
Copy link
Contributor

Hi @jqshuv!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented Jul 5, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit dcbaa25
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62c54770695ab40008b1b3ea
😎 Deploy Preview https://deploy-preview-7726--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 94 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 86 🟢 100 🟢 100 🟢 100 🟢 90 Report

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 6, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@@ -26,7 +26,7 @@
"waitFor": "postCreateCommand", // otherwise automated jest tests fail
"features": {
"node": {
"version": "14"
"version": "16"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we go directly to Node 18?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try it this evening but I think it should work if Docusaurus works on NodeJS 18.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, our docs recommend 18. I'm just not sure if devcontainer works with that...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it works and I already pushed it!
Screenshot_20220706-102832_Termius

@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Jul 6, 2022
@jqshuv jqshuv changed the title fix: bump devcontainer to node 16 fix: bump devcontainer to node 18 Jul 6, 2022
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

I don't use devcontainers myself so it's always maintained by community contributors. Thanks for taking this up!

@Josh-Cena Josh-Cena changed the title fix: bump devcontainer to node 18 chore: bump devcontainer to node 18 Jul 6, 2022
@Josh-Cena Josh-Cena merged commit 8a72b76 into facebook:main Jul 6, 2022
slorber pushed a commit that referenced this pull request Jul 14, 2022
* fix: bump devcontainer to node 16

* fix: bump devcontainer directly to nodejs 18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants