-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump devcontainer to node 18 #7726
Conversation
Hi @jqshuv! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
.devcontainer/devcontainer.json
Outdated
@@ -26,7 +26,7 @@ | |||
"waitFor": "postCreateCommand", // otherwise automated jest tests fail | |||
"features": { | |||
"node": { | |||
"version": "14" | |||
"version": "16" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we go directly to Node 18?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try it this evening but I think it should work if Docusaurus works on NodeJS 18.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, our docs recommend 18. I'm just not sure if devcontainer works with that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
I don't use devcontainers myself so it's always maintained by community contributors. Thanks for taking this up!
* fix: bump devcontainer to node 16 * fix: bump devcontainer directly to nodejs 18
Pre-flight checklist
Motivation
I decited to bump this version because I've tried to open this repo in a Remote-Container in vscode and got the error that you need at least NodeJS 16.
Test Plan
I've rebuilded the devcontainer and it worked without any errors.
Test links
Deploy preview: https://deploy-preview-7726--docusaurus-2.netlify.app/