Add config option for setting title of the blog sidebar #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-preview ready! Built with commit 3cb8612 |
JoelMarcey
approved these changes
Jun 14, 2018
There was a problem hiding this comment.
@jonathaningram Hi. Thanks for the PR.
This proposal seems reasonable to me.
Is there anything else you would like to do to move this from the [proposal] status?
|
@JoelMarcey nope I just put proposal in the title for meta so your team could decide if you wanted to accept it. Let me know if there's any changes you'd like from my end? I know there's no tests in here, but unless I missed them, I couldn't see any existing place in the codebase that had similar tests to which I could add. |
yangshun
changed the title
yangshun
approved these changes
Jun 15, 2018
|
I reran the job with SSH and Prettier was passing. Seems to be fine. Gonna merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This seems like one of the only (or the only) pieces of copy that I couldn't configure myself. I wanted to change the casing of the sidebar title.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Config:
Preview in UI:
Related PRs
#432