feat: add engines field to templates' package.json #7520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
See #7517 - having the
engines
explicitly stated in thepackage.json
rather than a transitive dependency allows tooling like Oryx to install the required minimum node version. See also johnnyreilly/blog.johnnyreilly.com#228 and https://blog.johnnyreilly.com/2022/05/28/azure-static-web-apps-node-16-oryxTest Plan
See the linked PR moving from failed builds to passing builds as this change is applied.
Test links
https://blog.johnnyreilly.com/2022/05/28/azure-static-web-apps-node-16-oryx
Related issues/PRs
See links above