Show onPageNav on mobile devices #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-preview ready! Built with commit b812b5a |
SleepWalker
force-pushed
the
662-onPageNav-for-mobile
branch
from
4ee2751 to
b812b5a
Compare
yangshun
approved these changes
Jun 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds support for onPageNav for mobile and tablet devices
This PR closes #662
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
ToC Hidden
ToC Shown
Tablet devices
For tablets I've decided to show onPageNav instead of sideNav. The sideNav is accessible through breadcrumbs menu like on mobile devices.