Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned action by SHA and included the URL for verification #7028

Closed

Conversation

naveensrinivasan
Copy link
Contributor

This is instead of this PR #6984

It was hard to rebase so opening a new one.

Specifically addressed this comment in this PR to include links to GitHub tags/commits in the comments to validate and test it.

#6984 (comment)

Motivation

Pin actions to a full length commit SHA

Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

Also, dependabot supports upgrading based on SHA.

Signed-off-by: naveensrinivasan [email protected]

Have you read the Contributing Guidelines on pull requests?

Test Plan

Related PRs

@Josh-Cena
Copy link
Collaborator

Closing because of #6984 (comment)

@Josh-Cena Josh-Cena closed this Mar 27, 2022
@Josh-Cena Josh-Cena added the closed: duplicate This issue or pull request already exists in another issue or pull request label Mar 27, 2022
@netlify
Copy link

netlify bot commented Mar 27, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 7017d86
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/623ff0fd5d0a160009115365
😎 Deploy Preview https://deploy-preview-7028--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 53
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7028--docusaurus-2.netlify.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA closed: duplicate This issue or pull request already exists in another issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants