Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct plugin example filename #7026

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Conversation

mem212
Copy link
Contributor

@mem212 mem212 commented Mar 27, 2022

The file name inside the my-plugin folder is index.js .

The file name inside the my-plugin folder is index.js .
@facebook-github-bot
Copy link
Contributor

Hi @MxhDx!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented Mar 27, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 5973f2d
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/623fc52ce0d44100090d2e62
😎 Deploy Preview https://deploy-preview-7026--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Mar 27, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 31
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7026--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena changed the title Correect Wrong file name docs: correct plugin example filename Mar 27, 2022
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 27, 2022
@Josh-Cena
Copy link
Collaborator

@MxhDx Please remember to sign the CLA. It's required for us to merge. PRs without CLA will be closed in two weeks.

@slorber
Copy link
Collaborator

slorber commented Apr 6, 2022

@MxhDx can you sign the CLA please?

@mem212
Copy link
Contributor Author

mem212 commented Apr 6, 2022

@MxhDx can you sign the CLA please?

Hi,
Sorry for the delay, I will in the next minutes.

@mem212
Copy link
Contributor Author

mem212 commented Apr 6, 2022

@MxhDx can you sign the CLA please?

Done.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 6, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants