Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make docs page wrapper take full height #7025

Merged
merged 2 commits into from
Mar 27, 2022
Merged

fix: make docs page wrapper take full height #7025

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5870f0f
fix: make page wrapper take full height
lex111 Mar 26, 2022
1bc5884
Better solution
lex111 Mar 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/docusaurus-theme-classic/src/theme/DocPage/Layout/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ import DocPageLayoutMain from '@theme/DocPage/Layout/Main';

import styles from './styles.module.css';

import {useDocsSidebar} from '@docusaurus/theme-common';
import {useDocsSidebar, ThemeClassNames} from '@docusaurus/theme-common';

export default function DocPageLayout({children}: Props): JSX.Element {
const sidebar = useDocsSidebar();
const [hiddenSidebarContainer, setHiddenSidebarContainer] = useState(false);
return (
<Layout>
<Layout wrapperClassName={ThemeClassNames.wrapper.docsPages}>
<BackToTopButton />
<div className={styles.docPage}>
{sidebar && (
Expand Down
9 changes: 8 additions & 1 deletion packages/docusaurus-theme-classic/src/theme/DocPage/Layout/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,17 @@
--doc-sidebar-hidden-width: 30px;
}

:global(.docs-wrapper) {
display: flex;
}

.docPage {
width: 100%;
}

.docPage,
.docMainContainer {
display: flex;
width: 100%;
}

.docSidebarContainer {
Expand Down
1 change: 0 additions & 1 deletion packages/docusaurus-theme-classic/src/theme/DocPage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ export default function DocPage(props: Props): JSX.Element {
/>
<HtmlClassNameProvider
className={clsx(
ThemeClassNames.wrapper.docsPages,
ThemeClassNames.page.docsDocPage,
props.versionMetadata.className,
)}>
Expand Down