Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix a few places of path handling #7023

Merged
merged 1 commit into from
Mar 26, 2022
Merged

refactor: fix a few places of path handling #7023

merged 1 commit into from
Mar 26, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

The actual error is found in the docs versioning CLI when an absolute path is used; fixed a few other places as well.

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 26, 2022
@netlify
Copy link

netlify bot commented Mar 26, 2022

[V2]

Name Link
🔨 Latest commit 49ccc65
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/623f23a1b2de7f000849cc18
😎 Deploy Preview https://deploy-preview-7023--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 49
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7023--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 806 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 613 kB
website/build/index.html 38.4 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 4957ec9 into main Mar 26, 2022
@Josh-Cena Josh-Cena deleted the jc/fix-path branch March 26, 2022 14:49
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants