Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): bump Infima, fix search issue due to broken CSS selector #6983

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Mar 24, 2022

Motivation

Bump Infima to fix Docusaurus search issue described in facebookincubator/infima#227

Search is a bit broken on all categories linking to a doc or a generated index

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

preview works + search works in prod after crawler runs

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Mar 24, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 24, 2022
@netlify
Copy link

netlify bot commented Mar 24, 2022

[V2]

Name Link
🔨 Latest commit 4489cb2
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/623c7d4f7b4780000869762d
😎 Deploy Preview https://deploy-preview-6983--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 61
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6983--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: +77 B (0%)

Total Size: 806 kB

Filename Size Change
website/build/assets/css/styles.********.css 105 kB +77 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/js/main.********.js 612 kB
website/build/index.html 38.8 kB

compressed-size-action

@slorber slorber merged commit 22c031c into main Mar 24, 2022
@slorber slorber deleted the slorber/fix-search-selector branch March 24, 2022 14:33
@Josh-Cena Josh-Cena changed the title fix(search): bump Infima, fix Docusaurus search issue due to broken CSS selector fix(search): bump Infima, fix search issue due to broken CSS selector Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants