Adds right-sidebar navigation made available in #475 to Blog Post pages #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…log Post pages
|
Deploy preview for docusaurus-preview ready! Built with commit 4d178bf |
|
I don't think that this requires a docs edit. However, I can if you folks think it should be updated. |
endiliey
reviewed
May 22, 2018
| @@ -123,6 +123,11 @@ class BlogPostLayout extends React.Component { | |||
| </a> | |||
| </div> | |||
| </Container> | |||
| {this.props.config.onPageNav == 'separate' && ( | |||
| <nav className="onPageNav"> | |||
| <OnPageNav rawContent={this.props.children} /> | |||
There was a problem hiding this comment.
@ericnakagawa I think you missed importing OnPageNav ☺
const OnPageNav = require('./nav/OnPageNav.js');
There was a problem hiding this comment.
I believe @endiliey is correct. That's why the Circle test is failing.
I am confused though how it would work for you without the require in your testing 😮
There was a problem hiding this comment.
Well that’s embarrassing!
@joel I modify my local npm-module usually. I’ll push a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently #475 added an extra onPageNav navigation control to the right side of Docs pages.
This change adds the onPageNav sidebar nav from the DocsLayout pages to BlogsLayout pages.
Motivation
I think Blog posts could benefit form having a navigation control.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Enable onPageNav, run site, navigate to a blog post that uses headers H1, H2 and not it in right sidebar navigation.
Related PRs
#475