-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(website): bump announcement bar + include Twitter link + refactor site colors #5351
Conversation
✔️ [V2] 🔨 Explore the source changes: dc5e3cb 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/611665a066b21f0008209d34 😎 Browse the preview: https://deploy-preview-5351--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5351--docusaurus-2.netlify.app/ |
Size Change: +9.23 kB (+1%) Total Size: 803 kB
ℹ️ View Unchanged
|
Thanks @lex111 , applied your suggestion but lighter for accessibility/contrast This was also a good pretext to apply some css var + hsl technique that I think we should use more for color palettes. The site colors remain exactly the same as before, it's just the way to create those colors that are now based on a lightnesss/darkness %, without requiring any preprocessor. This also helps highlight that we have colors with 2 different saturations. Didn't want to change that in that PR but maybe we should migrate to only one and just modify the lightness. I'd like to explore this a bit more but I think we could apply that in Infima so that users would only have to provide one base hue/saturation instead of a set of css variables. See https://blog.maximeheckel.com/posts/the-power-of-composition-with-css-variables/ |
Seems good, thanks!
Good idea, it's definitely worth to dig deeper. |
Motivation
Add a link to Twitter account in the announcement bar.
I guess it can make sense to bump the version from time to time too to ensure that people subscribe for updates and "thank" Docusaurus.