-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): auto-generated sidebars, frontmatter-less sites #4582
Conversation
[V1] Built with commit f23e823 |
Size Change: +33 B (0%) Total Size: 598 kB
ℹ️ View Unchanged
|
[V2] Built with commit f23e823 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4582--docusaurus-2.netlify.app/ |
This reverts commit c81da98
… sidebar generation code
# Conflicts: # packages/docusaurus-plugin-content-docs/src/docs.ts
Generating sidebar automatically is a good function. I suggest that when generating sidebar automatically, the system can add filtering rules to filter out some files (such as readme. md |
(emphasis mine) @slorber That is very true for us 😄. We have a numbered tutorial like this:
The files keep working as Any way to work around this? |
@borekb not sure to understand why you want the numbers in the URLs? In any case, you should be able to use a custom slug to add these numbers back, or simply disable the feature with |
It's just how it was, the tutorial part of our docs site used numbers in the URLs. Thanks for the tip with |
position?: number; | ||
collapsed?: boolean; | ||
|
||
// TODO should we allow "items" here? how would this work? would an "autogenerated" type be allowed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slorber Assuming based on this that I won't be able to do what I asked about in an earlier comment?
#3464 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I don't think it's possible atm but we may add support for it if there's a good use-case exposed clearly, preferably with a concrete example showcasing the problem (seeing sources is better)
Motivation
Fixes #3464
Good description of this PR here: #3464 (comment)
Breaking changes:
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
tests, preview, dogfooding