Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding scrollbar to header, only on mobile #452

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

maazadeeb
Copy link
Contributor

Motivation

Fixes #441. This has a different implementation than #444 in order to avoid #445. Only in the case of when screen size is lesser than 735px, we need a scrollbar.

Test Plan

  1. Add many dummy entries into the siteConfig.js.
  2. Use the Chrome devtools' "Toggle Device Mode" to simulate various responsive sizes. Note: Just make sure you refresh the page once when you switch to mobile mode. This guarantees that the page is loaded in the simulated mobile mode and any old CSS effects from the desktop mode are not into play.
  3. Also, test the search in every mode so that Search input bug (site) #445 doesn't come back.

scroll_doc

cc @JoelMarcey

@JoelMarcey
Copy link
Contributor

Love it (again)! 👍

@JoelMarcey JoelMarcey merged commit 0dad6d5 into facebook:master Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants