Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): bootstrap blog post page and card #2584

Merged
merged 8 commits into from
Apr 12, 2020

Conversation

fanny
Copy link
Contributor

@fanny fanny commented Apr 11, 2020

Motivation

I'm starting to develop the blog components and since the more isolated part is the post summary, I decided that this is the first component.

DISCLAIMER: You'll notice that the obtaining of data is a copy-paste from classic theme, this is the starter, in a near future, i'll move this to a custom hook, probably. If you have a better idea, lmk.

Have you read the Contributing Guidelines on pull requests?

👍

Test Plan

7294823D-309D-4FFE-A4B7-B730D8FE4C90_1_105_c

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@fanny fanny requested a review from yangshun April 11, 2020 21:59
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 11, 2020
@fanny fanny requested a review from lex111 April 11, 2020 21:59
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Apr 11, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 6dba676

https://deploy-preview-2584--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the right direction! Please refer to the comments.

@fanny fanny added the pr: new feature This PR adds a new API or behavior. label Apr 12, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you :D

@yangshun yangshun changed the title feat(v2): init blog post card feat(v2): bootstrap blog post page and card Apr 12, 2020
@yangshun yangshun merged commit f61b92d into master Apr 12, 2020
@fanny fanny deleted the fanny/bootstrap-blog-post-card branch April 16, 2020 11:11
@lex111 lex111 removed the pr: new feature This PR adds a new API or behavior. label Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants