Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move a cd step to the start of the init task #1710

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

italicize
Copy link
Contributor

@italicize italicize commented Jul 26, 2019

The cd step seems like the first step of "Install the Docusaurus init command," instead of the last step of "Create a GitHub repository and local clone."

The `cd` step seems like the first step of "Install the Docusaurus init command," instead of the last step of "Create a GitHub repository and local clone."
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 26, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit a4c39bb

https://deploy-preview-1710--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit a4c39bb

https://deploy-preview-1710--docusaurus-preview.netlify.com

@wgao19
Copy link
Contributor

wgao19 commented Jul 26, 2019

ok with the move around, but we need to update in all versioned docs.

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yangshun yangshun changed the title move a cd step to the start of the init task docs: move a cd step to the start of the init task Jul 26, 2019
@yangshun yangshun merged commit ab7e358 into facebook:master Jul 26, 2019
@italicize italicize deleted the patch-5 branch July 27, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants