Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v2): fix cannot import css from node_modules in userland #1463

Merged
merged 1 commit into from
May 16, 2019
Merged

fix(v2): fix cannot import css from node_modules in userland #1463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/docusaurus/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@
"webpack-bundle-analyzer": "^3.1.0",
"webpack-dev-server": "^3.2.1",
"webpack-merge": "^4.1.4",
"webpack-nicelog": "^2.3.1",
"webpack-node-externals": "^1.7.2"
"webpack-nicelog": "^2.3.1"
},
"peerDependencies": {
"react": "^16.8.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/docusaurus/src/client/PendingNavigation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import React from 'react';
import {Route, withRouter} from 'react-router-dom';
import nprogress from 'nprogress';
import preload from './preload';
import './nprogress.css';
import 'nprogress/nprogress.css';

nprogress.configure({showSpinner: false});

Expand Down
75 changes: 0 additions & 75 deletions packages/docusaurus/src/client/nprogress.css
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions packages/docusaurus/src/webpack/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
* LICENSE file in the root directory of this source tree.
*/

const nodeExternals = require('webpack-node-externals');
const path = require('path');
const StaticSiteGeneratorPlugin = require('static-site-generator-webpack-plugin');
const WebpackNiceLog = require('webpack-nicelog');
Expand Down Expand Up @@ -37,8 +36,6 @@ module.exports = function createServerConfig(props) {
globalObject: 'this',
},
target: 'node',
// No need to bundle its node_modules dependencies since we're bundling for static html generation (backend)
externals: [nodeExternals()],
plugins: [
// Wait until manifest from client bundle is generated
new WaitPlugin({
Expand Down
5 changes: 0 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13946,11 +13946,6 @@ webpack-nicelog@^2.3.1:
react-dev-utils "^5.0.1"
webpackbar "^2.6.1"

webpack-node-externals@^1.7.2:
version "1.7.2"
resolved "https://registry.yarnpkg.com/webpack-node-externals/-/webpack-node-externals-1.7.2.tgz#6e1ee79ac67c070402ba700ef033a9b8d52ac4e3"
integrity sha512-ajerHZ+BJKeCLviLUUmnyd5B4RavLF76uv3cs6KNuO8W+HuQaEs0y0L7o40NQxdPy5w0pcv8Ew7yPUAQG0UdCg==

webpack-sources@^0.2.0:
version "0.2.3"
resolved "https://registry.yarnpkg.com/webpack-sources/-/webpack-sources-0.2.3.tgz#17c62bfaf13c707f9d02c479e0dcdde8380697fb"
Expand Down