fix: change icon for navToggle #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit ac3851b |
|
Deploy preview for docusaurus-preview ready! Built with commit ac3851b |
yangshun
approved these changes
Apr 26, 2019
There was a problem hiding this comment.
Thanks @baloghroland! We'll merge this since it's an improvement, but in future we would refrain from doing so for the following reasons:
- We're focusing on v2 and will not want to add more things to v1. It'll be increased maintenance overhead.
- v1 controls tightly the CSS for the user and users might rely on those existing classes and override them. We may break some sites by removing the CSS they rely on.
We'll include this in a 1.9 release so that users are more aware of this change. Thanks for the improvement though, I really like it!
|
@yangshun thanks! Looking forward to contribute more in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #1230 , to change icon for navToggle to a more traditional one.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Changed the navToggle icon. This is before:
This is after:
Related PRs