chore: move to monorepo #1297
Merged
chore: move to monorepo #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
added
the
status: don't merge yet
|
Deploy preview for docusaurus-2 ready! Built with commit 8250a76 |
yangshun
approved these changes
Mar 23, 2019
|
It's mostly rename 😢 MY browser is lagging too. They should enable filter to not show rename |
|
Deploy preview for docusaurus-preview ready! Built with commit 8250a76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Move to monorepo with yarn workspaces and lerna. Still lot of WIP and CI will break.
Overall new structure is here https://github.com/endiliey/Docusaurus/tree/monorepo
Will need to start moving things to packages/* and publish stuff as scoped package under @Docusaurus
Changes:
yarnat root is needed to install all dependenciesprettier,test,lintcommand should be done at rootOne thing to note is that we still put v2 as
docusaurus-2name for now, but we'll switch back todocusauruslater on when we really cut v1 branch on GitHub and remove v1 package. This is because yarn workspaces doesnt allow two package with same name (although different version)Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
CI pass