fix: #1114 static files in blog/assets is not working
#1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-preview ready! Built with commit ffc790c |
|
will especially appreciate any feedback on how the tests can improved. i.e. |
endiliey
approved these changes
Dec 7, 2018
|
Thanks @tsmrachel 😊 |
aeneasr
reviewed
Dec 7, 2018
| const cssnano = require('cssnano'); | ||
| const autoprefixer = require('autoprefixer'); | ||
| const postcss = require('postcss'); | ||
| const path = require('path'); | ||
| const escapeStringRegexp = require('escape-string-regexp'); | ||
| const siteConfig = require('../../website/siteConfig.js'); |
There was a problem hiding this comment.
This broke docusaurus completely, see #1149
There was a problem hiding this comment.
Yeah this PR broke the release. My bad to overlook this. Will release a hotfix in ~1 hour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#1114
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
checked that it's working for docs - created docs/assets folder, added image to docs, and placed image in assets folder
checked that it's working for blog - created blog/assets folder, added image to blog, and placed image in assets folder
Related PRs
N.A.